Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use platform dependent mcount function #59097

Closed
Dylan-DPC-zz opened this issue Mar 11, 2019 · 0 comments · Fixed by #59506
Closed

Use platform dependent mcount function #59097

Dylan-DPC-zz opened this issue Mar 11, 2019 · 0 comments · Fixed by #59506
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Dylan-DPC-zz
Copy link

From #57244:

Follow up with @nagisa's comment on #57220. Not all platforms use the
mcount name. Added a test.

Since the PR was closed due to inactivity, this issue will track it.

cc @nagisa
@Dylan-DPC-zz Dylan-DPC-zz added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 11, 2019
@JohnTitor JohnTitor mentioned this issue Mar 28, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 31, 2019
@Centril
Rollup merge of rust-lang#59506 - JohnTitor:improve-mcount, r=nagisa
e3fb1aa 
Use platform dependent mcount function

close rust-lang#59097

This pull-request is based on rust-lang#57244 and [here](https://github.com/llvm-mirror/clang/search?q=MCountName&unscoped_MCountName).

r? @nagisa
bors added a commit that referenced this issue Mar 31, 2019
@bors
Auto merge of #59506 - JohnTitor:improve-mcount, r=nagisa
4c7e1a8 
Use platform dependent mcount function

close #59097

This pull-request is based on #57244 and [here](https://github.com/llvm-mirror/clang/search?q=MCountName&unscoped_MCountName).

r? @nagisa
Centril added a commit to Centril/rust that referenced this issue Mar 31, 2019
@Centril
Rollup merge of rust-lang#59506 - JohnTitor:improve-mcount, r=nagisa
245a0af 
Use platform dependent mcount function

close rust-lang#59097

This pull-request is based on rust-lang#57244 and [here](https://github.com/llvm-mirror/clang/search?q=MCountName&unscoped_MCountName).

r? @nagisa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use platform dependent mcount function JohnTitor/rust
1 participant
@Dylan-DPC-zz