Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest path normalization is too aggressive #59109

Closed
euclio opened this issue Mar 11, 2019 · 1 comment
Closed

compiletest path normalization is too aggressive #59109

euclio opened this issue Mar 11, 2019 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@euclio
Copy link
Contributor

euclio commented Mar 11, 2019

Notice that the backslashes in the help output for intra-doc link warnings are incorrectly converted to forward slashes:

= help: to escape `[` and `]` characters, just add '/' before them like `/[` or `/]`

The normalization is currently just a replace on all backslashes:

.replace("\\", "/") // normalize for paths on windows

@jonas-schievink jonas-schievink added the A-testsuite Area: The testsuite used to check the correctness of rustc label Mar 11, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Mar 12, 2019

Could we perhaps use the canonicalize method here?

Update: I suppose that would not actually address the issue at all. We could try to make the regexp itself smarter (e.g. have it not rewrite stuff inside quotes).

Centril added a commit to Centril/rust that referenced this issue Mar 28, 2019
…=oli-obk

compiletest: make path normalization smarter

Fixes rust-lang#59109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

3 participants