--disable-minification breaks doc builds #59157
Labels
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
jdm
added
the
T-rustdoc
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Mar 13, 2019
Fixes rust-lang#59157 This reverts commit b5ae4d5.
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Mar 15, 2019
…llaumeGomez Revert "Don't generate minification variable if minification disabled" Reverts rust-lang#58643 Fixes rust-lang#59157 rust-lang#58643 made us stop generating minification variables when minification is disabled, however they may still be needed for parent crates that were generated with minification (this will always be the case for libstd and libcore) r? @QuietMisdreavus @GuillaumeGomez
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Mar 16, 2019
…llaumeGomez Revert "Don't generate minification variable if minification disabled" Reverts rust-lang#58643 Fixes rust-lang#59157 rust-lang#58643 made us stop generating minification variables when minification is disabled, however they may still be needed for parent crates that were generated with minification (this will always be the case for libstd and libcore) r? @QuietMisdreavus @GuillaumeGomez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working around #58849 which was caused by minification, we have discovered that the resulting non-minified docs have a broken search index (
ReferenceError: N is not defined), and the resulting docs are limited to the single toplevel crate from the chosen manifest directory.The text was updated successfully, but these errors were encountered: