-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution guide does not mention our "no merge commits" policy #59233
Comments
@oli-obk I can take care of this one as it's quite a fresh experience :). |
I think we should only rebase when resolving merge conflict, or the review process has completed |
I agree with @lzutao that this policy is sound for actually merging the PR, but it might cause confusion for reviews. I've had a PR lying around for awhile, and when there is merge conflicts the 'waiting-on-author' label gets added so noone reviews it, but when I do the rebasing to get back my 'waiting-on-review' it seems as if Github sometimes loses context of previous reviews, which can be quite confusing... |
for the record: I personally want no rebasing and just merging, I'm just stating what the policy is. |
…i-obk Mention `no merge policy` in the CONTRIBUTING guide Issue: rust-lang#59233
…i-obk Mention `no merge policy` in the CONTRIBUTING guide Issue: rust-lang#59233
…i-obk Mention `no merge policy` in the CONTRIBUTING guide Issue: rust-lang#59233
Before we close this issue. Could we talk a bit about closing issues using keyword?
I think we should encourage contributors close issues by keywords in PR descriptions only. In short, we create another policy for closing issue. |
We expect everyone to rebase instead of merge and we also try to have fixup commits squashed into previous related commits. I think we should document this policy, since it keeps suprising newcomers.
The text was updated successfully, but these errors were encountered: