Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impl_trait_in_bindings to INCOMPLETE_FEATURES #60764

Closed
matthewjasper opened this issue May 12, 2019 · 1 comment · Fixed by #60770
Closed

Add impl_trait_in_bindings to INCOMPLETE_FEATURES #60764

matthewjasper opened this issue May 12, 2019 · 1 comment · Fixed by #60770
Labels
A-frontend Area: frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@matthewjasper
Copy link
Contributor

cc #60473, #60407, #58956
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-frontend Area: frontend (errors, parsing and HIR) labels May 12, 2019
@varkor
Copy link
Member

varkor commented May 12, 2019

If you want to fix this, all you need to do is add the string "impl_trait_in_bindings" to:

rust/src/libsyntax/feature_gate.rs

Lines 565 to 568 in 0df1e57

const INCOMPLETE_FEATURES: &[&str] = &[
"generic_associated_types",
"const_generics"
];

And update the tests that make use of that feature to catch the new warning that is emitted.

@varkor varkor added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label May 12, 2019
@Pulkit07 Pulkit07 mentioned this issue May 12, 2019
Merged
Pulkit07 added a commit to Pulkit07/rust that referenced this issue May 13, 2019
@Pulkit07
add impl_trait_in_bindings to INCOMPLETE_FEATURES
ea956e3 
impl_trait_in_bindings is not yet complete and can lead to compiler crashes.

Fixes rust-lang#60764.
Centril added a commit to Centril/rust that referenced this issue May 13, 2019
@Centril
Rollup merge of rust-lang#60770 - Pulkit07:issue60764, r=Centril
b698609 
add impl_trait_in_bindings to INCOMPLETE_FEATURES

impl_trait_in_bindings is not yet complete and can lead to compiler crashes.

Fixes rust-lang#60764.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add impl_trait_in_bindings to INCOMPLETE_FEATURES Pulkit07/rust
3 participants
@Centril @varkor @matthewjasper