-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotate-snippet emitter: Make use of -Z ui-testing
flag
#61811
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
E-help-wanted
Call for participation: Help is requested to fix this issue.
Comments
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-diagnostics
Area: Messages for errors, warnings, and lints
E-help-wanted
Call for participation: Help is requested to fix this issue.
labels
Jun 13, 2019
@rustbot claim |
phansch
added a commit
to phansch/rust
that referenced
this issue
Jul 25, 2019
This adds support for the `-Z ui-testing` flag to the new annotate-snippet diagnostic emitter. The support for the flag was added to `annotate-snippet-rs` in these PRs: * rust-lang/annotate-snippets-rs#3 * rust-lang/annotate-snippets-rs#5 Closes rust-lang#61811
Centril
added a commit
to Centril/rust
that referenced
this issue
Jul 26, 2019
…estebank librustc_errors: Support ui-testing flag in annotate-snippet emitter This adds support for the `-Z ui-testing` flag to the new annotate-snippet diagnostic emitter. Support for the flag was added to `annotate-snippet-rs` in these PRs: * rust-lang/annotate-snippets-rs#3 * rust-lang/annotate-snippets-rs#5 r? @estebank Closes rust-lang#61811
Centril
added a commit
to Centril/rust
that referenced
this issue
Jul 26, 2019
…estebank librustc_errors: Support ui-testing flag in annotate-snippet emitter This adds support for the `-Z ui-testing` flag to the new annotate-snippet diagnostic emitter. Support for the flag was added to `annotate-snippet-rs` in these PRs: * rust-lang/annotate-snippets-rs#3 * rust-lang/annotate-snippets-rs#5 r? @estebank Closes rust-lang#61811
Centril
added a commit
to Centril/rust
that referenced
this issue
Jul 26, 2019
…estebank librustc_errors: Support ui-testing flag in annotate-snippet emitter This adds support for the `-Z ui-testing` flag to the new annotate-snippet diagnostic emitter. Support for the flag was added to `annotate-snippet-rs` in these PRs: * rust-lang/annotate-snippets-rs#3 * rust-lang/annotate-snippets-rs#5 r? @estebank Closes rust-lang#61811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
E-help-wanted
Call for participation: Help is requested to fix this issue.
Part of #59346
To support
LL
lines in the first column of UI test output, we have to make use of the-Z ui-testing
flag and update theannotate-snippet
library.Relevant
FIXME
:rust/src/librustc_errors/annotate_snippet_emitter_writer.rs
Lines 176 to 179 in 57a3300
version needs to be released. Once that's done, we have to pass
self.ui_testing
as a second argument toDisplayListFormatter::new
.This issue has been assigned to @phansch via this comment.
The text was updated successfully, but these errors were encountered: