-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Built-in derive macros Encodable
, Decodable
, RustcEncodable
and RustcDecodable
are stable
#62048
Comments
The |
pre-triage: P-medium. removing nomination. @petrochenkov : do you want to be assigned to this? Or are you just sending out a general alert, but do not plan to fix it? |
PR for crater - #62507. |
Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` `Encodable` and `Decodable` were deprecated before 1.0 and emitted an unsuppressable warning all this time. `#[bench]` is a part of the custom test framework feature and cannot be used meaningfully on stable, only as `cfg(false)`. Crater results can be found in rust-lang#62507 (comment) and below. This PR also reroutes the tracking issue for `feature(test)` from rust-lang#27812 (compiler internals) to rust-lang#50297 (custom test frameworks). Closes rust-lang#62048
Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` `Encodable` and `Decodable` were deprecated before 1.0 and emitted an unsuppressable warning all this time. `#[bench]` is a part of the custom test framework feature and cannot be used meaningfully on stable, only as `cfg(false)`. Crater results can be found in #62507 (comment) and below. This PR also reroutes the tracking issue for `feature(test)` from #27812 (compiler internals) to #50297 (custom test frameworks). Closes #62048
// core::prelude pub mod rust_2024 { |
use std::io; fn main() {
} |
// core::prelude pub mod rust_2024 { fn main() {
}[workspace] [workspace.metadata.webcontents] ...MIT License Copyright (c) [year] [fullname] Permission is hereby granted, free of charge, to any person obtaining a copy The above copyright notice and this permission notice shall be included in all THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR async function main() { main().catch(console.error); |
The macros produce paths like
serialize::foo
orrustc_serialize::foo
and I suspect that the feature gating was supposed to happen when you writeextern crate serialize
to bring thatserialize
into scope.However, you can easily write
use anything as serialize
, andrustc_serialize
is a stable crate on crates.io, so this kind of feature gating doesn't work.After #62042 lands we should try to un-stabilize them and test it with crater.
The text was updated successfully, but these errors were encountered: