Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#62081 #62101

Closed
rust-highfive opened this issue Jun 24, 2019 · 1 comment · Fixed by #62105
Closed

miri no longer builds after rust-lang/rust#62081 #62101

rust-highfive opened this issue Jun 24, 2019 · 1 comment · Fixed by #62105
Assignees
@eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #62081, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @RalfJung, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 24, 2019
@JohnTitor JohnTitor mentioned this issue Jun 25, 2019
Merged
@JohnTitor
Copy link
Member

I think rust-lang/miri#787 fixes this so I opened #62105. Feel free to close it if it's invalid.

@oli-obk oli-obk added P-medium Medium priority and removed I-nominated labels Jun 27, 2019
Centril added a commit to Centril/rust that referenced this issue Jun 28, 2019
@Centril
Rollup merge of rust-lang#62105 - JohnTitor:update-miri, r=RalfJung
66e8257 
Update miri

Fixes rust-lang#62101

r? @RalfJung
Centril added a commit to Centril/rust that referenced this issue Jun 28, 2019
@Centril
Rollup merge of rust-lang#62105 - JohnTitor:update-miri, r=RalfJung
af5cb09 
Update miri

Fixes rust-lang#62101

r? @RalfJung
Centril added a commit to Centril/rust that referenced this issue Jun 28, 2019
@Centril
Rollup merge of rust-lang#62105 - JohnTitor:update-miri, r=RalfJung
18be48b 
Update miri

Fixes rust-lang#62101

r? @RalfJung
bors added a commit that referenced this issue Jun 29, 2019
@bors
Auto merge of #62105 - JohnTitor:update-miri, r=RalfJung
8ec3942 
Update miri

Fixes #62101

r? @RalfJung
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update miri JohnTitor/rust
5 participants
@eddyb @RalfJung @oli-obk @rust-highfive @JohnTitor