Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor 1.36 rustdoc regression: \] after a link is not treated as an escape #62770

Closed
MaulingMonkey opened this issue Jul 17, 2019 · 1 comment · Fixed by #62789
Closed

Minor 1.36 rustdoc regression: \] after a link is not treated as an escape #62770

MaulingMonkey opened this issue Jul 17, 2019 · 1 comment · Fixed by #62789
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@MaulingMonkey
Copy link
Contributor

MaulingMonkey commented Jul 17, 2019 •
edited
Loading

A minor change in behavior between 1.35.0 and 1.36.0. Repro example here:

/// \[This escapes both brackets\]
/// \[[This escapes only the left bracket as of 1.36.0](https://www.google.com/)\]
pub fn example() {
}

Run a standard cargo doc. In 1.36.0, the link will display \] instead of ] after the link, whereas in 1.35 it will display ] after the link.
@MaulingMonkey MaulingMonkey changed the title rustdoc \] after link not treated as an escape Minor 1.36 rustdoc regression: \] after a link is not treated as an escape Jul 17, 2019
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 17, 2019
@ehuss
Copy link
Contributor

ehuss commented Jul 18, 2019

I filed pulldown-cmark/pulldown-cmark#375 for this.

@ehuss ehuss mentioned this issue Jul 18, 2019
Merged
bors added a commit that referenced this issue Jul 20, 2019
@bors
Auto merge of #62789 - GuillaumeGomez:update-pulldown-cmark, r=Manish…
95b1fe5 
…earth

Update pulldown-cmark version

Fixes #62571.
Fixes #62770.
Fixes #62552.

cc @rust-lang/rustdoc @Centril @pietroalbini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pulldown-cmark version GuillaumeGomez/rust
3 participants
@ehuss @MaulingMonkey @jonas-schievink