Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fuchsia to actually_monotonic #64196

Closed
joshlf opened this issue Sep 5, 2019 · 1 comment · Fixed by #64198
Closed

Add Fuchsia to actually_monotonic #64196

joshlf opened this issue Sep 5, 2019 · 1 comment · Fixed by #64198

Comments

@joshlf
Copy link
Contributor

joshlf commented Sep 5, 2019

std's internal actually_monotonic function is used to determine which platforms' clocks are truly monotonic. Those that aren't (that have been observed to sometimes go backwards in practice) require more expensive machinery to ensure monotonicity of the Instant type on those platforms.

Fuchsia provides a truly monotonic clock, so we should add it to the list of platforms for which actually_monotonic returns true.
@joshlf
Copy link
Contributor Author

joshlf commented Sep 5, 2019

cc @cramertj @tmandry

@cramertj cramertj mentioned this issue Sep 5, 2019
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 6, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#64198 - cramertj:fuchsia-monotonic, r=alexc…
16ee07e 
…richton

Add Fuchsia to actually_monotonic

Fuchsia provides a fully monotonic clock.

Fix rust-lang#64196

cc @joshlf @tmandry

r? @alexcrichton
@bors bors closed this as completed in 61fcd05 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Fuchsia to actually_monotonic cramertj/rust
1 participant
@joshlf