-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port rust python scripts to python3 #65063
Comments
We will want to also track LLVM pretty closely here. |
AFAIK they all work with python3 already, so this would mostly be a matter of defaults, like the Installed scripts like |
So we probably want to switch our CI and such to use python 3 by default but be careful when accepting patches to ensure compat with python 2, right? Is that a correct read of the situation? |
Yep -- maybe even leave one CI deliberately on python2.7 to be sure. |
@cuviper We still have some |
The |
Oh? I didn't know this, thanks for the info! Anyway, doesn't hurt to get rid of it in full python3 source code. :) |
Make a test compatible across python versions. Progress on rust-lang#65063 This PR allows this test to work on both python2 and python3, and it also allows `./x.py test` to fully complete on my system without python2 installed at all.
Make a test compatible across python versions. Progress on rust-lang#65063 This PR allows this test to work on both python2 and python3, and it also allows `./x.py test` to fully complete on my system without python2 installed at all.
Make a test compatible across python versions. Progress on #65063 This PR allows this test to work on both python2 and python3, ~~and it also allows `./x.py test` to fully complete on my system without python2 installed at all.~~
Since python2 support will stop at the end of the year, I think it's time to move on. Will send the PR tomorrow.
The text was updated successfully, but these errors were encountered: