Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messed up docs for std::task::Waker #65323

Closed
djrenren opened this issue Oct 12, 2019 · 0 comments · Fixed by #65336
Closed

Messed up docs for std::task::Waker #65323

djrenren opened this issue Oct 12, 2019 · 0 comments · Fixed by #65336
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@djrenren
Copy link
Contributor

This should be an easy one, but the docs for std::task::Waker look like this:
image

But it should probably just say Send and Sync not trait@Send and trait@Sync
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Oct 12, 2019
@ghost ghost mentioned this issue Oct 12, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Oct 13, 2019
@Centril
Rollup merge of rust-lang#65336 - BO41:typo, r=petrochenkov
1a2835b 
Fix typo in task::Waker

fixes  rust-lang#65323

in `libstd/error.rs` there are a few mentions of `trait@Send` and `trait@Sync`. Are they wrong as well?
@bors bors closed this as completed in d10702b Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in task::Waker
2 participants
@djrenren @jonas-schievink