Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#64873 #65356

Closed
rust-highfive opened this issue Oct 13, 2019 · 5 comments · Fixed by #65412
Closed

miri no longer builds after rust-lang/rust#64873 #65356

rust-highfive opened this issue Oct 13, 2019 · 5 comments · Fixed by #65412
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #64873, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @popzxc, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @wesleywiser, the PR reviewer, and nominating for compiler team prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2019
@popzxc
Copy link
Contributor

popzxc commented Oct 13, 2019

Yeah, I will try to figure out how to fix miri.

@phansch
Copy link
Member

phansch commented Oct 13, 2019

@popzxc Sorry, saw this issue after the fact - If Miri is failing because of the renamed testopt, I have a PR for compiletest-rs open with a potential fix: Manishearth/compiletest-rs#189

@popzxc
Copy link
Contributor

popzxc commented Oct 13, 2019

Sure, no problem.

@RalfJung
Copy link
Member

RalfJung commented Oct 13, 2019 via email

@phansch
Copy link
Member

phansch commented Oct 13, 2019

We had avoided the "nightly" feature of compiletest-rs in Miri exactly because of this... But recently enabled it again due to other failures. Should we rather try to use the stable variant again?

Both variants are currently not working:

This was referenced Oct 14, 2019
@bors bors closed this as completed in 437ca55 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants