Bump Miri #65278

jonhoo · 2019-10-10T19:21:54Z

Brings in rust-lang/miri#972 and other fixes

rust-highfive · 2019-10-10T19:22:04Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-10-10T19:22:05Z

⚠️ Warning ⚠️

These commits modify submodules.

jonhoo · 2019-10-10T19:22:21Z

r? @RalfJung

RalfJung · 2019-10-10T20:06:31Z

Thanks!
@bors r+

bors · 2019-10-10T20:06:33Z

📌 Commit ab9cb70 has been approved by RalfJung

rust-highfive · 2019-10-10T21:41:18Z

The job LinuxTools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-10T19:22:33.6685135Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-10T19:22:33.6739966Z ##[command]git config gc.auto 0
2019-10-10T19:22:33.6742566Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-10T19:22:33.6744048Z ##[command]git config --get-all http.proxy
2019-10-10T19:22:33.6746257Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65278/merge:refs/remotes/pull/65278/merge
---
2019-10-10T20:55:50.8701187Z    Compiling mdbook-linkcheck v0.3.0
2019-10-10T20:56:02.9229265Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-10-10T20:56:06.9413260Z     Finished release [optimized] target(s) in 7m 41s
2019-10-10T20:58:00.7334762Z Error: there are broken links
2019-10-10T20:58:00.7337025Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-10-10T20:58:00.7340549Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-10-10T20:58:00.7340813Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-10-10T20:58:00.7341591Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-10-10T20:58:00.7341851Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk_engine/forest/struct.Forest.html" returned 404 Not Found
---
2019-10-10T21:03:12.0876822Z    Compiling toml v0.5.3
2019-10-10T21:03:21.7708763Z    Compiling url v2.1.0
2019-10-10T21:03:49.3037223Z    Compiling cargo_metadata v0.8.0
2019-10-10T21:04:10.6754483Z    Compiling clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
2019-10-10T21:09:44.5588505Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-10T21:09:44.5589140Z    |
2019-10-10T21:09:44.5589373Z 12 | #[plugin_registrar]
2019-10-10T21:09:44.5589979Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-10T21:09:44.5590164Z    |
---
2019-10-10T21:40:58.9132797Z normalized stderr:
2019-10-10T21:40:58.9133217Z error[E0080]: Miri evaluation error: the evaluated program panicked
2019-10-10T21:40:58.9133880Z   --> /checkout/src/libcore/panicking.rs:84:14
2019-10-10T21:40:58.9134029Z    |
2019-10-10T21:40:58.9134065Z 84 |     unsafe { panic_impl(&pi) }
2019-10-10T21:40:58.9134138Z    |
2019-10-10T21:40:58.9134195Z    = note: inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9
2019-10-10T21:40:58.9134238Z    = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-10T21:40:58.9134238Z    = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-10T21:40:58.9134281Z note: inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at $DIR/file_manipulation.rs:11:20
2019-10-10T21:40:58.9134598Z    |
2019-10-10T21:40:58.9134634Z 11 |     let mut file = File::create(path).unwrap();
2019-10-10T21:40:58.9134697Z    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-10T21:40:58.9134735Z    = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-10T21:40:58.9134735Z    = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-10T21:40:58.9134772Z    = note: inside call to closure at /checkout/src/libstd/rt.rs:48:73
2019-10-10T21:40:58.9134836Z    = note: inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5
2019-10-10T21:40:58.9135228Z    = note: inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13
2019-10-10T21:40:58.9135304Z    = note: inside call to closure at /checkout/src/libstd/panicking.rs:288:40
2019-10-10T21:40:58.9135655Z    = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5
2019-10-10T21:40:58.9136021Z    = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9
2019-10-10T21:40:58.9136987Z    = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25
2019-10-10T21:40:58.9137142Z    = note: inside call to `std::rt::lang_start::<()>`
2019-10-10T21:40:58.9137376Z 
2019-10-10T21:40:58.9137420Z error: aborting due to previous error
2019-10-10T21:40:58.9137466Z 
---
2019-10-10T21:40:58.9138053Z 
2019-10-10T21:40:58.9138122Z +error[E0080]: Miri evaluation error: the evaluated program panicked
2019-10-10T21:40:58.9138377Z +  --> /checkout/src/libcore/panicking.rs:84:14
2019-10-10T21:40:58.9138427Z +   |
2019-10-10T21:40:58.9138488Z +84 |     unsafe { panic_impl(&pi) }
2019-10-10T21:40:58.9138587Z +   |
2019-10-10T21:40:58.9138637Z +   = note: inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9
2019-10-10T21:40:58.9138721Z +   = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-10T21:40:58.9138721Z +   = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-10T21:40:58.9138883Z +note: inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at $DIR/file_manipulation.rs:11:20
2019-10-10T21:40:58.9139271Z +   |
2019-10-10T21:40:58.9139320Z +11 |     let mut file = File::create(path).unwrap();
2019-10-10T21:40:58.9139373Z +   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-10T21:40:58.9139445Z +   = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-10T21:40:58.9139445Z +   = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-10T21:40:58.9139500Z +   = note: inside call to closure at /checkout/src/libstd/rt.rs:48:73
2019-10-10T21:40:58.9139557Z +   = note: inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5
2019-10-10T21:40:58.9140100Z +   = note: inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13
2019-10-10T21:40:58.9140348Z +   = note: inside call to closure at /checkout/src/libstd/panicking.rs:288:40
2019-10-10T21:40:58.9140899Z +   = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5
2019-10-10T21:40:58.9141414Z +   = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9
2019-10-10T21:40:58.9141769Z +   = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25
2019-10-10T21:40:58.9141871Z +   = note: inside call to `std::rt::lang_start::<()>`
2019-10-10T21:40:58.9141920Z +
2019-10-10T21:40:58.9141952Z +error: aborting due to previous error
2019-10-10T21:40:58.9141983Z +
2019-10-10T21:40:58.9141983Z +
2019-10-10T21:40:58.9142190Z +For more information about this error, try `rustc --explain E0080`.
2019-10-10T21:40:58.9142226Z +
2019-10-10T21:40:58.9142246Z 
2019-10-10T21:40:58.9142279Z The actual stderr differed from the expected stderr.
2019-10-10T21:40:58.9142334Z Actual stderr saved to /tmp/compiletestUY58oE/file_manipulation.stderr
2019-10-10T21:40:58.9142371Z To update references, run this command from build directory:
2019-10-10T21:40:58.9142577Z tests/run-pass/update-references.sh '/tmp/compiletestUY58oE' 'file_manipulation.rs'
2019-10-10T21:40:58.9142733Z error: 1 errors occurred comparing output.
2019-10-10T21:40:58.9142766Z status: exit code: 1
2019-10-10T21:40:58.9142766Z status: exit code: 1
2019-10-10T21:40:58.9143285Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/file_manipulation.rs" "-L" "/tmp/compiletestUY58oE" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestUY58oE/file_manipulation.stage-id" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zmiri-disable-isolation" "-L" "/tmp/compiletestUY58oE/file_manipulation.stage-id.aux" "-A" "unused"
2019-10-10T21:40:58.9143524Z ------------------------------------------
2019-10-10T21:40:58.9143567Z 
2019-10-10T21:40:58.9143738Z ------------------------------------------
2019-10-10T21:40:58.9143773Z stderr:
2019-10-10T21:40:58.9143773Z stderr:
2019-10-10T21:40:58.9143953Z ------------------------------------------
2019-10-10T21:40:58.9151362Z {"message":"Miri evaluation error: the evaluated program panicked","code":{"code":"E0080","explanation":"\nThis error indicates that the compiler was unable to sensibly evaluate an\nconstant expression that had to be evaluated. Attempting to divide by 0\nor causing integer overflow are two ways to induce this error. For example:\n\n```compile_fail,E0080\nenum Enum {\n    X = (1 << 500),\n    Y = (1 / 0)\n}\n```\n\nEnsure that the expressions given can be evaluated as the desired integer type.\nSee the FFI section of the Reference for more information about using a custom\ninteger type:\n\nhttps://doc.rust-lang.org/reference.html#ffi-attributes\n"},"level":"error","spans":[{"file_name":"/checkout/src/libcore/panicking.rs","byte_start":3348,"byte_end":3363,"line_start":84,"line_end":84,"column_start":14,"column_end":29,"is_primary":true,"text":[{"text":"    unsafe { panic_impl(&pi) }","highlight_start":14,"highlight_end":29}],"label":"Miri evaluation error: the evaluated program panicked","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at tests/run-pass/file_manipulation.rs:11:20","code":null,"level":"note","spans":[{"file_name":"tests/run-pass/file_manipulation.rs","byte_start":359,"byte_end":386,"line_start":11,"line_end":11,"column_start":20,"column_end":47,"is_primary":true,"text":[{"text":"    let mut file = File::create(path).unwrap();","highlight_start":20,"highlight_end":47}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"inside call to `main` at /checkout/src/libstd/rt.rs:61:34","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to closure at /checkout/src/libstd/rt.rs:48:73","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to closure at /checkout/src/libstd/panicking.rs:288:40","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::rt::lang_start_internal` at /checkout/src/libstd/rt.rs:61:5","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::rt::lang_start::<()>`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0080]: Miri evaluation error: the evaluated program panicked\n  --> /checkout/src/libcore/panicking.rs:84:14\n   |\n84 |     unsafe { panic_impl(&pi) }\n   |              ^^^^^^^^^^^^^^^ Miri evaluation error: the evaluated program panicked\n   |\n   = note: inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9\n   = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23\nnote: inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at tests/run-pass/file_manipulation.rs:11:20\n  --> tests/run-pass/file_manipulation.rs:11:20\n   |\n11 |     let mut file = File::create(path).unwrap();\n   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34\n   = note: inside call to closure at /checkout/src/libstd/rt.rs:48:73\n   = note: inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5\n   = note: inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13\n   = note: inside call to closure at /checkout/src/libstd/panicking.rs:288:40\n   = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5\n   = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9\n   = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25\n   = note: inside call to `std::rt::lang_start_internal` at /checkout/src/libstd/rt.rs:61:5\n   = note: inside call to `std::rt::lang_start::<()>`\n\n"}
2019-10-10T21:40:58.9152965Z {"message":"For more information about this error, try `rustc --explain E0080`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0080`.\n"}
2019-10-10T21:40:58.9153006Z 
2019-10-10T21:40:58.9153178Z ------------------------------------------
2019-10-10T21:40:58.9153220Z 
---
2019-10-10T21:40:58.9412068Z Verifying status of clippy-driver...
2019-10-10T21:40:58.9422007Z Verifying status of miri...
2019-10-10T21:40:58.9433994Z This PR updated 'src/tools/miri', verifying if status is 'test-pass'...
2019-10-10T21:40:58.9442219Z 
2019-10-10T21:40:58.9442731Z ⚠️ We detected that this PR updated 'miri', but its tests failed.
2019-10-10T21:40:58.9442790Z 
2019-10-10T21:40:58.9443028Z If you do intend to update 'miri', please check the error messages above and
2019-10-10T21:40:58.9443071Z commit another update.
2019-10-10T21:40:58.9443092Z 
2019-10-10T21:40:58.9443279Z If you do NOT intend to update 'miri', please ensure you did not accidentally
2019-10-10T21:40:58.9443486Z change the submodule at 'src/tools/miri'. You may ask your reviewer for the
2019-10-10T21:40:58.9443525Z proper steps.
2019-10-10T21:40:58.9460637Z   local time: Thu Oct 10 21:40:58 UTC 2019
2019-10-10T21:40:59.1239034Z   network time: Thu, 10 Oct 2019 21:40:59 GMT
2019-10-10T21:40:59.1239133Z == end clock drift check ==
2019-10-10T21:40:59.1239133Z == end clock drift check ==
2019-10-10T21:40:59.6202260Z ##[error]Bash exited with code '3'.
2019-10-10T21:40:59.6261905Z ##[section]Starting: Checkout
2019-10-10T21:40:59.6263459Z ==============================================================================
2019-10-10T21:40:59.6263502Z Task         : Get sources
2019-10-10T21:40:59.6263539Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung · 2019-10-10T21:45:42Z

Oops, looks like something is wrong.

@bors r-

RalfJung · 2019-10-10T21:46:29Z

Ah, that's the panic issue @Aaron1011 mentioned.
EDIT: No it isn't; see below.

RalfJung · 2019-10-10T22:31:53Z

But why doesn't it trigger a toolstate failure...? It also works fine locally to run Miri against latest rustc master.

RalfJung · 2019-10-11T08:22:40Z

@christianpoveda the only failing test is

2019-10-10T21:40:58.9153389Z failures:
2019-10-10T21:40:58.9153599Z [ui] run-pass/file_manipulation.rs

Any idea what could be going on? See the build log for more details.

RalfJung · 2019-10-11T08:25:25Z

My guess is that the working directory is not the same. You cannot rely on ./tests to be the Miri tests folder; when running in Rust's CI the working dir is a different one.

Does it work to use current_exe?

This is a critical bug; it prevents us from updating Miri in rustc.

pvdrz · 2019-10-11T08:29:26Z

I can change the test to create the file in cwd instead. would that fix the problem?

RalfJung · 2019-10-11T08:40:58Z

Hm, polluting the build dir isn't great either.

@RalfJung

Avoid using the tests folder for the file manipualtion test rust-lang/rust#65278 r? @RalfJung

RalfJung · 2019-10-11T10:14:20Z

@jonhoo could you update the Miri in here? The bug should be fixed upstream.

jonhoo · 2019-10-11T14:43:06Z

@RalfJung done!

RalfJung · 2019-10-11T14:48:14Z

Thanks!
@bors r+

bors · 2019-10-11T14:48:15Z

📌 Commit dbb73dc has been approved by RalfJung

rust-highfive · 2019-10-11T17:13:20Z

The job LinuxTools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-11T14:43:40.2634303Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-11T14:43:40.2731696Z ##[command]git config gc.auto 0
2019-10-11T14:43:40.3314742Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-11T14:43:40.3384468Z ##[command]git config --get-all http.proxy
2019-10-11T14:43:40.3563558Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65278/merge:refs/remotes/pull/65278/merge
---
2019-10-11T16:25:24.9988699Z    Compiling mdbook-linkcheck v0.3.0
2019-10-11T16:25:42.1314524Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-10-11T16:25:46.5641084Z     Finished release [optimized] target(s) in 8m 22s
2019-10-11T16:27:30.3196265Z Error: there are broken links
2019-10-11T16:27:30.3203099Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-10-11T16:27:30.3204018Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-10-11T16:27:30.3204386Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-10-11T16:27:30.3204746Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-10-11T16:27:30.3205090Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk_engine/forest/struct.Forest.html" returned 404 Not Found
---
2019-10-11T16:33:00.1324983Z    Compiling url v2.1.0
2019-10-11T16:33:10.5324214Z    Compiling toml v0.5.3
2019-10-11T16:33:39.4253486Z    Compiling cargo_metadata v0.8.0
2019-10-11T16:34:01.9197938Z    Compiling clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
2019-10-11T16:40:03.1698130Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-11T16:40:03.1699938Z    |
2019-10-11T16:40:03.1700547Z 12 | #[plugin_registrar]
2019-10-11T16:40:03.1707033Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-11T16:40:03.1707675Z    |
---
2019-10-11T17:13:14.6777022Z normalized stderr:
2019-10-11T17:13:14.6777071Z error[E0080]: Miri evaluation error: the evaluated program panicked
2019-10-11T17:13:14.6777364Z   --> /checkout/src/libcore/panicking.rs:84:14
2019-10-11T17:13:14.6777411Z    |
2019-10-11T17:13:14.6777452Z 84 |     unsafe { panic_impl(&pi) }
2019-10-11T17:13:14.6777560Z    |
2019-10-11T17:13:14.6777608Z    = note: inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9
2019-10-11T17:13:14.6777692Z    = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-11T17:13:14.6777692Z    = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-11T17:13:14.6777748Z note: inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at $DIR/fs.rs:11:20
2019-10-11T17:13:14.6778560Z    |
2019-10-11T17:13:14.6778605Z 11 |     let mut file = File::create(path).unwrap();
2019-10-11T17:13:14.6778653Z    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-11T17:13:14.6778721Z    = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-11T17:13:14.6778721Z    = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-11T17:13:14.6778773Z    = note: inside call to closure at /checkout/src/libstd/rt.rs:48:73
2019-10-11T17:13:14.6778826Z    = note: inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5
2019-10-11T17:13:14.6779355Z    = note: inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13
2019-10-11T17:13:14.6779434Z    = note: inside call to closure at /checkout/src/libstd/panicking.rs:288:40
2019-10-11T17:13:14.6780185Z    = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5
2019-10-11T17:13:14.6780640Z    = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9
2019-10-11T17:13:14.6781096Z    = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25
2019-10-11T17:13:14.6781353Z    = note: inside call to `std::rt::lang_start::<()>`
2019-10-11T17:13:14.6781391Z 
2019-10-11T17:13:14.6781447Z error: aborting due to previous error
2019-10-11T17:13:14.6781474Z 
---
2019-10-11T17:13:14.6782062Z 
2019-10-11T17:13:14.6782102Z +error[E0080]: Miri evaluation error: the evaluated program panicked
2019-10-11T17:13:14.6782313Z +  --> /checkout/src/libcore/panicking.rs:84:14
2019-10-11T17:13:14.6782374Z +   |
2019-10-11T17:13:14.6782412Z +84 |     unsafe { panic_impl(&pi) }
2019-10-11T17:13:14.6782629Z +   |
2019-10-11T17:13:14.6782672Z +   = note: inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9
2019-10-11T17:13:14.6782728Z +   = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-11T17:13:14.6782728Z +   = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23
2019-10-11T17:13:14.6782791Z +note: inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at $DIR/fs.rs:11:20
2019-10-11T17:13:14.6783060Z +   |
2019-10-11T17:13:14.6783116Z +11 |     let mut file = File::create(path).unwrap();
2019-10-11T17:13:14.6783158Z +   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-11T17:13:14.6783200Z +   = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-11T17:13:14.6783200Z +   = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34
2019-10-11T17:13:14.6783243Z +   = note: inside call to closure at /checkout/src/libstd/rt.rs:48:73
2019-10-11T17:13:14.6783314Z +   = note: inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5
2019-10-11T17:13:14.6783743Z +   = note: inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13
2019-10-11T17:13:14.6783835Z +   = note: inside call to closure at /checkout/src/libstd/panicking.rs:288:40
2019-10-11T17:13:14.6784234Z +   = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5
2019-10-11T17:13:14.6784654Z +   = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9
2019-10-11T17:13:14.6785058Z +   = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25
2019-10-11T17:13:14.6785282Z +   = note: inside call to `std::rt::lang_start::<()>`
2019-10-11T17:13:14.6785319Z +
2019-10-11T17:13:14.6785372Z +error: aborting due to previous error
2019-10-11T17:13:14.6785407Z +
2019-10-11T17:13:14.6785407Z +
2019-10-11T17:13:14.6785663Z +For more information about this error, try `rustc --explain E0080`.
2019-10-11T17:13:14.6785723Z +
2019-10-11T17:13:14.6785745Z 
2019-10-11T17:13:14.6785782Z The actual stderr differed from the expected stderr.
2019-10-11T17:13:14.6785824Z Actual stderr saved to /tmp/compiletestU8fjVy/fs.stderr
2019-10-11T17:13:14.6785887Z To update references, run this command from build directory:
2019-10-11T17:13:14.6786120Z tests/run-pass/update-references.sh '/tmp/compiletestU8fjVy' 'fs.rs'
2019-10-11T17:13:14.6786197Z error: 1 errors occurred comparing output.
2019-10-11T17:13:14.6786253Z status: exit code: 1
2019-10-11T17:13:14.6786253Z status: exit code: 1
2019-10-11T17:13:14.6786767Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/fs.rs" "-L" "/tmp/compiletestU8fjVy" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestU8fjVy/fs.stage-id" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zmiri-disable-isolation" "-L" "/tmp/compiletestU8fjVy/fs.stage-id.aux" "-A" "unused"
2019-10-11T17:13:14.6787048Z ------------------------------------------
2019-10-11T17:13:14.6787078Z 
2019-10-11T17:13:14.6787294Z ------------------------------------------
2019-10-11T17:13:14.6787334Z stderr:
2019-10-11T17:13:14.6787334Z stderr:
2019-10-11T17:13:14.6787618Z ------------------------------------------
2019-10-11T17:13:14.6796088Z {"message":"Miri evaluation error: the evaluated program panicked","code":{"code":"E0080","explanation":"\nThis error indicates that the compiler was unable to sensibly evaluate an\nconstant expression that had to be evaluated. Attempting to divide by 0\nor causing integer overflow are two ways to induce this error. For example:\n\n```compile_fail,E0080\nenum Enum {\n    X = (1 << 500),\n    Y = (1 / 0)\n}\n```\n\nEnsure that the expressions given can be evaluated as the desired integer type.\nSee the FFI section of the Reference for more information about using a custom\ninteger type:\n\nhttps://doc.rust-lang.org/reference.html#ffi-attributes\n"},"level":"error","spans":[{"file_name":"/checkout/src/libcore/panicking.rs","byte_start":3348,"byte_end":3363,"line_start":84,"line_end":84,"column_start":14,"column_end":29,"is_primary":true,"text":[{"text":"    unsafe { panic_impl(&pi) }","highlight_start":14,"highlight_end":29}],"label":"Miri evaluation error: the evaluated program panicked","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at tests/run-pass/fs.rs:11:20","code":null,"level":"note","spans":[{"file_name":"tests/run-pass/fs.rs","byte_start":358,"byte_end":385,"line_start":11,"line_end":11,"column_start":20,"column_end":47,"is_primary":true,"text":[{"text":"    let mut file = File::create(path).unwrap();","highlight_start":20,"highlight_end":47}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"inside call to `main` at /checkout/src/libstd/rt.rs:61:34","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to closure at /checkout/src/libstd/rt.rs:48:73","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to closure at /checkout/src/libstd/panicking.rs:288:40","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::rt::lang_start_internal` at /checkout/src/libstd/rt.rs:61:5","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"inside call to `std::rt::lang_start::<()>`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0080]: Miri evaluation error: the evaluated program panicked\n  --> /checkout/src/libcore/panicking.rs:84:14\n   |\n84 |     unsafe { panic_impl(&pi) }\n   |              ^^^^^^^^^^^^^^^ Miri evaluation error: the evaluated program panicked\n   |\n   = note: inside call to `core::panicking::panic_fmt` at /checkout/src/libcore/macros.rs:18:9\n   = note: inside call to `std::result::unwrap_failed` at /checkout/src/libcore/result.rs:933:23\nnote: inside call to `std::result::Result::<std::fs::File, std::io::Error>::unwrap` at tests/run-pass/fs.rs:11:20\n  --> tests/run-pass/fs.rs:11:20\n   |\n11 |     let mut file = File::create(path).unwrap();\n   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   = note: inside call to `main` at /checkout/src/libstd/rt.rs:61:34\n   = note: inside call to closure at /checkout/src/libstd/rt.rs:48:73\n   = note: inside call to closure at /checkout/src/libstd/sys_common/backtrace.rs:129:5\n   = note: inside call to `std::sys_common::backtrace::__rust_begin_short_backtrace::<[closure@DefId(1:6033 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:48:13\n   = note: inside call to closure at /checkout/src/libstd/panicking.rs:288:40\n   = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:284:5\n   = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9\n   = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:6032 ~ std[1695]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:47:25\n   = note: inside call to `std::rt::lang_start_internal` at /checkout/src/libstd/rt.rs:61:5\n   = note: inside call to `std::rt::lang_start::<()>`\n\n"}
2019-10-11T17:13:14.6798722Z {"message":"For more information about this error, try `rustc --explain E0080`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0080`.\n"}
2019-10-11T17:13:14.6798804Z 
2019-10-11T17:13:14.6799043Z ------------------------------------------
2019-10-11T17:13:14.6799077Z 
---
2019-10-11T17:13:14.7112229Z Verifying status of clippy-driver...
2019-10-11T17:13:14.7128606Z Verifying status of miri...
2019-10-11T17:13:14.7142680Z This PR updated 'src/tools/miri', verifying if status is 'test-pass'...
2019-10-11T17:13:14.7154660Z 
2019-10-11T17:13:14.7155424Z ⚠️ We detected that this PR updated 'miri', but its tests failed.
2019-10-11T17:13:14.7155626Z 
2019-10-11T17:13:14.7156032Z If you do intend to update 'miri', please check the error messages above and
2019-10-11T17:13:14.7156249Z commit another update.
2019-10-11T17:13:14.7156373Z 
2019-10-11T17:13:14.7156753Z If you do NOT intend to update 'miri', please ensure you did not accidentally
2019-10-11T17:13:14.7157206Z change the submodule at 'src/tools/miri'. You may ask your reviewer for the
2019-10-11T17:13:14.7157398Z proper steps.
2019-10-11T17:13:14.7179764Z   local time: Fri Oct 11 17:13:14 UTC 2019
2019-10-11T17:13:14.8813176Z   network time: Fri, 11 Oct 2019 17:13:14 GMT
2019-10-11T17:13:14.8814736Z == end clock drift check ==
2019-10-11T17:13:14.8814736Z == end clock drift check ==
2019-10-11T17:13:15.7881508Z ##[error]Bash exited with code '3'.
2019-10-11T17:13:15.7935285Z ##[section]Starting: Checkout
2019-10-11T17:13:15.7937449Z ==============================================================================
2019-10-11T17:13:15.7937513Z Task         : Get sources
2019-10-11T17:13:15.7937587Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pvdrz · 2019-10-11T17:32:57Z

That's odd, I have no idea why creating the file is failing. Is it there some restriction about creating files in the build directory or something?

RalfJung · 2019-10-11T18:25:19Z

@bors r-

Yeah might be a permission thing.

RalfJung · 2019-10-11T20:43:46Z

Maybe we should use /tmp/miri_test_fs.<random>.rs as the filename? Or rather, copy some logic from tempdir for the base dir. (We cannot depend on crates in Miri's compiletests, I think.)

RalfJung · 2019-10-11T20:45:36Z

Oh wait, we have https://doc.rust-lang.org/nightly/std/env/fn.temp_dir.html, we don't need to copy anything. :)

RalfJung · 2019-10-12T15:47:55Z

@jonhoo we are using a temporary dir in Miri now; could you bump Miri again?

jonhoo · 2019-10-12T17:43:38Z

@RalfJung done

RalfJung · 2019-10-12T17:56:12Z

Thanks! This time let's wait until CI here in the PR is green before bothering bors.

@bors delegate+

Once CI is green, please do bors r=RalfJung.

bors · 2019-10-12T17:56:13Z

✌️ @jonhoo can now approve this pull request

jonhoo · 2019-10-13T02:36:00Z

@bors r=RalfJung

bors · 2019-10-13T02:36:01Z

📌 Commit 397b679 has been approved by RalfJung

RalfJung · 2019-10-13T09:29:29Z

Unfortunately, Miri got broken by #64873 @bors r-

RalfJung · 2019-10-14T07:43:39Z

@jonhoo do you want me to take over? Might be easier if I do the update directly instead of asking you to do submodule bumps all the time.^^

Usually Miri updates work much smoother than this, but sometimes new things just keep coming up... this time, a combination of new filesystem tests and a libtest change (breaking Miri's test suite) and also #64823 makes for quite a bumpy update.

jonhoo · 2019-10-14T14:36:09Z

Haha, that's probably easier! I'll close this and you open a new one?

RalfJung · 2019-10-14T16:02:54Z

Thanks; new one is at #65412.

Bump Miri

ab9cb70

rust-highfive assigned nikomatsakis Oct 10, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2019

rust-highfive assigned RalfJung and unassigned nikomatsakis Oct 10, 2019

jonhoo mentioned this pull request Oct 10, 2019

Support atomic_fence instrinstic rust-lang/miri#972

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2019

pvdrz mentioned this pull request Oct 11, 2019

Avoid using the tests folder for the file manipulation test rust-lang/miri#985

Merged

bors added a commit to rust-lang/miri that referenced this pull request Oct 11, 2019

Auto merge of #985 - christianpoveda:fix-fs-path, r=RalfJung

e10d9d3

Avoid using the tests folder for the file manipualtion test rust-lang/rust#65278 r? @RalfJung

Bump Miri again for rust-lang/miri#985

dbb73dc

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 11, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2019

Bump Miri again for tempdir fix

397b679

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2019

jonhoo closed this Oct 14, 2019

jonhoo mentioned this pull request Jan 27, 2020

Shim intrinsics::atomic_singlethreadfence, etc. rust-lang/miri#1150

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Miri #65278

Bump Miri #65278

jonhoo commented Oct 10, 2019

rust-highfive commented Oct 10, 2019

rust-highfive commented Oct 10, 2019

jonhoo commented Oct 10, 2019

RalfJung commented Oct 10, 2019

bors commented Oct 10, 2019

rust-highfive commented Oct 10, 2019

RalfJung commented Oct 10, 2019

RalfJung commented Oct 10, 2019 •

edited

Loading

RalfJung commented Oct 10, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

pvdrz commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

jonhoo commented Oct 11, 2019

RalfJung commented Oct 11, 2019

bors commented Oct 11, 2019

rust-highfive commented Oct 11, 2019

pvdrz commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 12, 2019

jonhoo commented Oct 12, 2019

RalfJung commented Oct 12, 2019

bors commented Oct 12, 2019

jonhoo commented Oct 13, 2019

bors commented Oct 13, 2019

RalfJung commented Oct 13, 2019 via email

RalfJung commented Oct 14, 2019 •

edited

Loading

jonhoo commented Oct 14, 2019

RalfJung commented Oct 14, 2019 •

edited

Loading

Bump Miri #65278

Bump Miri #65278

Conversation

jonhoo commented Oct 10, 2019

rust-highfive commented Oct 10, 2019

rust-highfive commented Oct 10, 2019

jonhoo commented Oct 10, 2019

RalfJung commented Oct 10, 2019

bors commented Oct 10, 2019

rust-highfive commented Oct 10, 2019

RalfJung commented Oct 10, 2019

RalfJung commented Oct 10, 2019 • edited Loading

RalfJung commented Oct 10, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

pvdrz commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

jonhoo commented Oct 11, 2019

RalfJung commented Oct 11, 2019

bors commented Oct 11, 2019

rust-highfive commented Oct 11, 2019

pvdrz commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 11, 2019

RalfJung commented Oct 12, 2019

jonhoo commented Oct 12, 2019

RalfJung commented Oct 12, 2019

bors commented Oct 12, 2019

jonhoo commented Oct 13, 2019

bors commented Oct 13, 2019

RalfJung commented Oct 13, 2019 via email

RalfJung commented Oct 14, 2019 • edited Loading

jonhoo commented Oct 14, 2019

RalfJung commented Oct 14, 2019 • edited Loading

RalfJung commented Oct 10, 2019 •

edited

Loading

RalfJung commented Oct 14, 2019 •

edited

Loading

RalfJung commented Oct 14, 2019 •

edited

Loading