Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#67661 #67708

Closed
rust-highfive opened this issue Dec 29, 2019 · 1 comment · Fixed by #67821
Closed

rls no longer builds after rust-lang/rust#67661 #67708

rust-highfive opened this issue Dec 29, 2019 · 1 comment · Fixed by #67821
Assignees
@Xanewok
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #67661, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2019
@mati865 mati865 mentioned this issue Dec 31, 2019
Merged
@pnkfelix
Copy link
Member

pnkfelix commented Jan 2, 2020

triage P-medium removing nomination.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jan 2, 2020
@matthiaskrgr matthiaskrgr mentioned this issue Jan 3, 2020
Merged
bors added a commit that referenced this issue Jan 5, 2020
@bors
Auto merge of #67821 - matthiaskrgr:submodule_upd, r=Xanewok
0731573 
submodules: update rls from fed7a31 to 7010eee

Changes:
````
Update Clippy
Update cargo.
Correct two links to the json-error-emitter
````

Fixes #67708
@bors bors closed this as completed in fe26416 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update rls from fed7a31 to 7010eee matthiaskrgr/rust
3 participants
@pnkfelix @Xanewok @rust-highfive