-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM: rustllvm produces unsilenceable warnings on new versions of GCC (9.2.0) #69078
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
petrochenkov
added
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
labels
Feb 11, 2020
We might want to hide the LLVM/rustllvm build log from users -- similar to how Cargo hides upstream, non-local, path deps. We'd probably want to stick this behind an option or something like that for those who are compiling LLVM after changing it locally. |
contrun
pushed a commit
to contrun/llvm-project
that referenced
this issue
Feb 25, 2020
See issue rust-lang/rust#69078 for details --- [cmake] Disable GCC 9's -Winit-list-lifetime warning in ArrayRef Summary: This is a new warning which fires when one stores a reference to the initializer_list contents in a way which may outlive the initializer_list which it came from. In llvm this warning is triggered whenever someone uses the initializer_list ArrayRef constructor. This is indeed a dangerous thing to do (I myself was bitten by that at least once), but it is not more dangerous than calling other ArrayRef constructors with temporary objects -- something which we are used to and have accepted as a tradeoff for ArrayRef's efficiency. Currently, this warnings generates so much output that it completely obscures any actionable warnings, so this patch disables it. Reviewers: rnk, aaron.ballman Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70122 (cherry picked from commit 6c2151b)
cuviper
pushed a commit
to rust-lang/llvm-project
that referenced
this issue
Feb 25, 2020
See issue rust-lang/rust#69078 for details --- [cmake] Disable GCC 9's -Winit-list-lifetime warning in ArrayRef Summary: This is a new warning which fires when one stores a reference to the initializer_list contents in a way which may outlive the initializer_list which it came from. In llvm this warning is triggered whenever someone uses the initializer_list ArrayRef constructor. This is indeed a dangerous thing to do (I myself was bitten by that at least once), but it is not more dangerous than calling other ArrayRef constructors with temporary objects -- something which we are used to and have accepted as a tradeoff for ArrayRef's efficiency. Currently, this warnings generates so much output that it completely obscures any actionable warnings, so this patch disables it. Reviewers: rnk, aaron.ballman Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70122 (cherry picked from commit 6c2151b) Co-authored-by: Pavel Labath <pavel@labath.sk>
jonas-schievink
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Feb 26, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Feb 26, 2020
update llvm to silence gcc 9 warnings Closes rust-lang#69078
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this issue
Feb 27, 2020
update llvm to silence gcc 9 warnings Closes rust-lang#69078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
... which are pretty annoying.
It probably wouldn't be a problem if Cargo didn't cache the warnings and didn't display them on every build, even if
rustllvm
isn't actually built.Example of the warnings:
This is fixed in LLVM upstream (llvm/llvm-project@6c2151b), so that commit can be cherry-picked into our LLVM fork.
The commit seems to be included into LLVM 10, but I'm not sure when #67759 will be able to land.
The text was updated successfully, but these errors were encountered: