Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#69358 #69383

Closed
rust-highfive opened this issue Feb 22, 2020 · 0 comments · Fixed by #69428
Closed

rls no longer builds after rust-lang/rust#69358 #69383

rust-highfive opened this issue Feb 22, 2020 · 0 comments · Fixed by #69428
Assignees
@Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69358, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @ehuss, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @ehuss, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2020
@matthiaskrgr matthiaskrgr mentioned this issue Feb 24, 2020
Merged
bors added a commit that referenced this issue Feb 25, 2020
@bors
Auto merge of #69428 - matthiaskrgr:submodule_upd, r=Xanewok
e9b9617 
submodules: update rls from 10bf331 to 5fde462

Changes:
````
Update cargo.
````

Fixes #69383
Fixes #69286

r? @Xanewok
@bors bors closed this as completed in 3fb7694 Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update rls from 10bf331 to 5fde462 matthiaskrgr/rust
2 participants
@Xanewok @rust-highfive