Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: don't block further CI results on tidy/fmt #69613

Closed
CAD97 opened this issue Mar 1, 2020 · 1 comment · Fixed by #69688
Closed

CI: don't block further CI results on tidy/fmt #69613

CAD97 opened this issue Mar 1, 2020 · 1 comment · Fixed by #69688
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@CAD97
Copy link
Contributor

CAD97 commented Mar 1, 2020

Some irlo context.

Currently, if a PR has even trivial tidy/fmt errors, the tidy/fmt error early-exits the PR smoke test CI and reports just the tidy/fmt error.

This can be problematic because of the long test cycle; it would reduce the number of required pushes/CI runs if CI could report both tidy/fmt nits alongside the test harness state.
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 1, 2020
@Mark-Simulacrum
Copy link
Member

We can likely move tidy to the mingw-check builder and skip it on the longer builder.

@JohnTitor JohnTitor mentioned this issue Mar 4, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 17, 2020
@Centril
Rollup merge of rust-lang#69688 - JohnTitor:move-tidy, r=Mark-Simulacrum
2b7c6a3 
Move tidy check to mingw-check

Fixes rust-lang#69613
Centril added a commit to Centril/rust that referenced this issue Mar 17, 2020
@Centril
Rollup merge of rust-lang#69688 - JohnTitor:move-tidy, r=Mark-Simulacrum
3e8c948 
Move tidy check to mingw-check

Fixes rust-lang#69613
@bors bors closed this as completed in 91426e9 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move tidy check to mingw-check JohnTitor/rust
3 participants
@jonas-schievink @Mark-Simulacrum @CAD97