ICE when building docopt with rustc nightly on Travis CI #70041

ghedo · 2020-03-16T13:28:36Z

As of rustc 1.43.0-nightly (45ebd58 2020-03-15) the Travis CI builds of https://github.com/cloudflare/quiche are failing due to rustc crashing. The crash happens when building the docopt crate, which is a dependency of one of quiche's subcrates.

Unfortunately I wasn't able to reproduce this locally, so I can't try the latest master or try to prepare a minimal reproducer, but I can reproduce this realiably on Travis CI, see e.g.
https://travis-ci.com/github/cloudflare/quiche/jobs/298502269
https://travis-ci.com/github/cloudflare/quiche/jobs/298521787
https://travis-ci.com/github/cloudflare/quiche/jobs/298536148
https://travis-ci.com/github/cloudflare/quiche/jobs/298535326

Could this have something to do with Travis CI specifically?

Code

As per above, I don't have specific code that reproduces this. I can only reproduce when building the docopt crate as part of quiche on Travis CI.

Error output

   Compiling docopt v1.1.0
     Running `rustc --crate-name docopt --edition=2018 /home/travis/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/docopt-1.1.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C debuginfo=2 -C metadata=60637fd07855c546 -C extra-filename=-60637fd07855c546 --out-dir /home/travis/build/cloudflare/quiche/tools/apps/target/debug/deps -L dependency=/home/travis/build/cloudflare/quiche/tools/apps/target/debug/deps --extern lazy_static=/home/travis/build/cloudflare/quiche/tools/apps/target/debug/deps/liblazy_static-9097ff8143d19ca4.rmeta --extern regex=/home/travis/build/cloudflare/quiche/tools/apps/target/debug/deps/libregex-e22dcf23ec571abd.rmeta --extern serde=/home/travis/build/cloudflare/quiche/tools/apps/target/debug/deps/libserde-4039d5b385e0dfe9.rmeta --extern strsim=/home/travis/build/cloudflare/quiche/tools/apps/target/debug/deps/libstrsim-161e6c2eb076d56e.rmeta --cap-lints allow -D warnings`
thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', src/librustc/hir/mod.rs:81:37

Backtrace

thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', src/librustc/hir/mod.rs:81:37
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/backtrace-0.3.44/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/git.luolix.top-1ecc6299db9ec823/backtrace-0.3.44/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1069
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1427
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:218
  10: rustc_driver::report_ice
  11: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:513
  12: rust_begin_unwind
             at src/libstd/panicking.rs:417
  13: core::panicking::panic_fmt
             at src/libcore/panicking.rs:111
  14: core::panicking::panic
             at src/libcore/panicking.rs:54
  15: core::ops::function::FnOnce::call_once
  16: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors for rustc::ty::query::queries::hir_owner>::compute
  17: rustc::dep_graph::graph::DepGraph::with_task_impl
  18: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  19: rustc::hir::map::Map::get_entry
  20: rustc::hir::map::Map::find
  21: rustc_passes::dead::MarkSymbolVisitor::check_def_id
  22: rustc_hir::intravisit::walk_item
  23: rustc_passes::dead::check_crate
  24: rustc_session::utils::<impl rustc_session::session::Session>::time
  25: rustc_interface::passes::analysis::{{closure}}::{{closure}}
  26: rustc_session::utils::<impl rustc_session::session::Session>::time
  27: rustc_interface::passes::analysis
  28: rustc::ty::query::__query_compute::analysis
  29: rustc::dep_graph::graph::DepGraph::with_task_impl
  30: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  31: rustc::ty::context::tls::enter_global
  32: rustc_interface::interface::run_compiler_in_existing_thread_pool
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

The text was updated successfully, but these errors were encountered:

ghedo · 2020-03-16T13:31:32Z

FTR, the docopt crate was last updated almost a year ago, so this is not due to some new code there https://crates.io/crates/docopt

Centril · 2020-03-16T14:59:50Z

Let's see if we can shrink the input to something suitable for a regression test.

@rustbot ping cleanup

Also cc @Zoxc

rustbot · 2020-03-16T14:59:53Z

Hey Cleanup Crew ICE-breakers! This bug has been identified as a good
"Cleanup ICE-breaking candidate". In case it's useful, here are some
instructions for tackling these sorts of bugs. Maybe take a look?
Thanks! <3

cc @AminArria @chrissimpkins @contrun @DutchGhost @elshize @ethanboxx @h-michael @HallerPatrick @hdhoang @hellow554 @imtsuki @jakevossen5 @KarlK90 @LeSeulArtichaut @matheus-consoli @mental32 @nmccarty @Noah-Kennedy @pard68 @PeytonT @pierreN @Redblueflame @RobbieClarken @RobertoSnap @robjtede @SarthakSingh31 @senden9 @shekohex @sinato @spastorino @turboladen @woshilapin @yerke

Zoxc · 2020-03-16T15:13:52Z

This seems to be an issue with #68944. It could be we're calling hir_owner with something that isn't an HIR owner, in which case it should be changed to return None instead of panicking. It's odd that it can't be reproduced though.

Zoxc · 2020-03-16T15:31:54Z

I can reproduce it by cargo build on https://github.com/docopt/docopt.rs.

ghedo · 2020-03-16T15:53:58Z

It's odd that it can't be reproduced though.

I just realized I wasn't actually using rust nightly when I tried to reproduce locally 🤦‍♂️ so that explains that...

dtolnay · 2020-03-16T18:07:36Z

Minimized:

[package]
name = "docopt"
version = "0.0.0"
edition = "2018"

macro_rules! regex {
    () => {};
}

#[allow(dead_code)]
mod parse {
    use regex;
}

@eddyb

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

@eddyb

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

nikomatsakis · 2020-03-19T14:24:44Z

@rustbot assign @Zoxc

ghedo added C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2020

ghedo changed the title ~~ICE when building docopt with rustc nightly~~ ICE when building docopt with rustc nightly on Travis CI Mar 16, 2020

ghedo mentioned this issue Mar 16, 2020

recovery: windowed min and max filter implementation cloudflare/quiche#398

Merged

rustbot added the ICEBreaker-Cleanup-Crew Helping to "clean up" bugs with minimal examples and bisections label Mar 16, 2020

jonas-schievink removed the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Mar 16, 2020

dtolnay pinned this issue Mar 16, 2020

jonas-schievink added P-high High priority and removed E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example labels Mar 16, 2020

Zoxc mentioned this issue Mar 16, 2020

Allow hir().find to return None #70051

Merged

Centril added a commit to Centril/rust that referenced this issue Mar 16, 2020

Rollup merge of rust-lang#70051 - Zoxc:opt-find, r=eddyb

9d325cf

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

ecstatic-morse unpinned this issue Mar 16, 2020

Manishearth added a commit to Manishearth/rust that referenced this issue Mar 17, 2020

Rollup merge of rust-lang#70051 - Zoxc:opt-find, r=eddyb

c0f826a

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

cuviper mentioned this issue Mar 17, 2020

Use structopt instead of docopt rayon-rs/rayon#737

Open

tesuji mentioned this issue Mar 18, 2020

Compile "docopt": thread 'rustc' panicked at 'called Option::unwrap() on a None value' #70097

Closed

JohnTitor mentioned this issue Mar 18, 2020

Bump sass from 1.26.2 to 1.26.3 rust-lang/crates.io#2274

Merged

Centril removed the P-high High priority label Mar 18, 2020

Centril added P-high High priority and removed I-nominated labels Mar 18, 2020

djc mentioned this issue Mar 18, 2020

Allow features prefixed with "crate:" for namespaced-features rust-lang/crates.io#2277

Closed

jonas-schievink mentioned this issue Mar 18, 2020

Rustc panic: Option::unwrap() on None at src/librustc/hir/mod.rs:81:37 #70124

Closed

Centril assigned Centril and unassigned Centril Mar 19, 2020

rustbot assigned Zoxc Mar 19, 2020

This was referenced Mar 20, 2020

ICE when compiling or checking docopt crate #70178

Closed

ICE compiling docopt v1.1.0 with rustc f509b26a7 2020-03-18 with sanitizer=address #70192

Closed

bors closed this as completed in ce0af8a Mar 22, 2020

This was referenced Mar 23, 2020

ICE when compiling docopt on rustc 1.44.0-nightly (f509b26a7 2020-03-18) #70302

Closed

thread 'rustc' panicked at 'called Option::unwrap() on a None value', src/librustc/hir/mod.rs:81:37 #70353

Closed

azriel91 mentioned this issue Mar 28, 2020

Add rust-src component so WASM target may build. amethyst/builder#11

Open

matthiaskrgr mentioned this issue Mar 31, 2020

thread 'rustc' panicked at 'called Option::unwrap() on a None value', src/librustc/hir/mod.rs:81:37 #70599

Closed

jonas-schievink mentioned this issue Apr 4, 2020

Internal compiler error when installing a package in nightly mode. #70778

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ICE when building docopt with rustc nightly on Travis CI #70041

ICE when building docopt with rustc nightly on Travis CI #70041

ghedo commented Mar 16, 2020 •

edited by rustbot

Loading

ghedo commented Mar 16, 2020

Centril commented Mar 16, 2020

rustbot commented Mar 16, 2020

Zoxc commented Mar 16, 2020 •

edited

Loading

Zoxc commented Mar 16, 2020

ghedo commented Mar 16, 2020

dtolnay commented Mar 16, 2020

nikomatsakis commented Mar 19, 2020

ICE when building docopt with rustc nightly on Travis CI #70041

ICE when building docopt with rustc nightly on Travis CI #70041

Comments

ghedo commented Mar 16, 2020 • edited by rustbot Loading

Code

Meta

Error output

ghedo commented Mar 16, 2020

Centril commented Mar 16, 2020

rustbot commented Mar 16, 2020

Zoxc commented Mar 16, 2020 • edited Loading

Zoxc commented Mar 16, 2020

ghedo commented Mar 16, 2020

dtolnay commented Mar 16, 2020

nikomatsakis commented Mar 19, 2020

ghedo commented Mar 16, 2020 •

edited by rustbot

Loading

Zoxc commented Mar 16, 2020 •

edited

Loading