Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELEASES.md section for 1.10 contains an entry concerning a nightly feature #70247

Closed
jplatte opened this issue Mar 21, 2020 · 1 comment · Fixed by #70250
Closed

RELEASES.md section for 1.10 contains an entry concerning a nightly feature #70247

jplatte opened this issue Mar 21, 2020 · 1 comment · Fixed by #70250
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@jplatte
Copy link
Contributor

jplatte commented Mar 21, 2020

concat_idents! is unstable to this day, but RELEASES.md has this to say about Rust 1.10:

Allow concat_idents! in type positions as well as in expression positions.

The release notes shouldn't really be talking about changes to unstable features, right?
@Mark-Simulacrum
Copy link
Member

Yes, they shouldn't be, this was likely just an oversight at the time. We would be able to accept a PR nixing the entry, I think, even if there's probably not much point (given that 1.10 is quite old at this point).

@jplatte jplatte mentioned this issue Mar 21, 2020
Merged
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Mar 21, 2020
Centril added a commit to Centril/rust that referenced this issue Mar 22, 2020
@Centril
Rollup merge of rust-lang#70250 - jplatte:patch-1, r=Centril
aade079 
Remove wrong entry from RELEASES.md

resolves rust-lang#70247
@bors bors closed this as completed in bc3dad1 Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove wrong entry from RELEASES.md jplatte/rust
3 participants
@jplatte @jonas-schievink @Mark-Simulacrum