Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tidy should run first on the buildbots #7085

Closed
huonw opened this issue Jun 12, 2013 · 4 comments
Closed

make tidy should run first on the buildbots #7085

huonw opened this issue Jun 12, 2013 · 4 comments

Comments

@huonw
Copy link
Member

huonw commented Jun 12, 2013

It seems silly to spend 20 minutes building if there is trailing whitespace or a line > 100 chars, which is only discovered at the start of make check.
@pnkfelix
Copy link
Member

Or maybe tidy should be one of the default make targets, since it is cheap to run?

@pnkfelix
Copy link
Member

(maybe both. huonw's point is legitimate; it would save buildbot time.)

@pnkfelix
Copy link
Member

part of #8058 .

(I feel like I've seen evidence that this actually happened at some point recently?)

@huonw
Copy link
Member Author

huonw commented Feb 23, 2014

Triage: no change to the buildbots, but now we have have travis CI building every PR, so people get tidy feedback fast and this is essentially irrelevant.

@huonw huonw closed this as completed Feb 23, 2014
@pnkfelix pnkfelix mentioned this issue Jul 8, 2014
Merged
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
@bors
Auto merge of rust-lang#7085 - Jarcho:manual_map_autoderef, r=giraffate
faa9756 
Don't allow adjustments for `manual_map`

fixes: rust-lang#7077

The other option here would be to add the return type to the closure. It would be fine for simple types, but longer types can be rather unwieldy. Could also implement the adjustment manually.

changelog: Don't lint `manual_map` when type adjustments are added. e.g. autoderef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pnkfelix @huonw