Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extern mod doesn't work in windows test runner #7103

Closed
huonw opened this issue Jun 13, 2013 · 3 comments
Closed

extern mod doesn't work in windows test runner #7103

huonw opened this issue Jun 13, 2013 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@huonw
Copy link
Member

huonw commented Jun 13, 2013

Presumably since the tests are just concatenated together as submodules.

(I guess there is already an issue for this, but I couldn't find it.)
@huonw huonw mentioned this issue Jun 13, 2013
Closed
@pnkfelix
Copy link
Member

visiting for triage, email from 2013-08-12.

I'm wondering if there should be a metabug for "issues that stem from the combine-the-modules testing strategy we used on windows." (decided to take the plunge and make that metabug)

@pnkfelix
Copy link
Member

Part of #8844.

@huonw
Copy link
Member Author

huonw commented Jan 31, 2014

Closing as a dupe of #7416.

@huonw huonw closed this as completed Jan 31, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
@bors
Auto merge of rust-lang#7108 - rust-lang:fix-return-try-err, r=Manish…
c569d33 
…earth

un-double `return` on try_err

This fixes rust-lang#7103 by looking at the parent expression and omitting the "return " in the suggestion when its already a `return` expression.

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pnkfelix @huonw