Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: "attempted dynamic environment-capture" is a bad error message #7118

Closed
bblum opened this issue Jun 13, 2013 · 1 comment · Fixed by #7531
Closed

RFC: "attempted dynamic environment-capture" is a bad error message #7118

bblum opened this issue Jun 13, 2013 · 1 comment · Fixed by #7531
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Jun 13, 2013

I propose replacing it with can't capture dynamic environment in a fn item; use the || { ... } closure form instead

Though, I note from #322 that this error message has been around since the days of rustboot. So maybe somebody has sentimental attachment to it...
@pcwalton
Copy link
Contributor

Yes, this is a terrible error message. I wanted to change it when I rewrote resolve but I didn't want to update the compile-fail tests that relied on the error message being what it was.

@ngsankha ngsankha mentioned this issue Jul 1, 2013
Merged
@bors bors closed this as completed in 1cee9d4 Jul 3, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue May 6, 2021
@bors
Auto merge of rust-lang#7118 - TaKO8Ki:fix-false-positive-in-comparis…
14f1551 
…on-chain, r=giraffate

Fix a false-positive inside const fn in `comparison_chain`

closes rust-lang/rust-clippy#7082

changelog: fix a false-positive inside const fn in [`comparison_chain`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the attempted dynamic environment-capture error message ngsankha/rust
2 participants
@pcwalton @bblum