Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for RefCell::take #71395

Closed
1 of 2 tasks
ThinkChaos opened this issue Apr 21, 2020 · 7 comments
Closed
1 of 2 tasks

Tracking Issue for RefCell::take #71395

ThinkChaos opened this issue Apr 21, 2020 · 7 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ThinkChaos
Copy link
Contributor

ThinkChaos commented Apr 21, 2020

This is a tracking issue for #![feature(refcell_take)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

@ThinkChaos ThinkChaos added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Apr 21, 2020
@jonas-schievink

This comment has been minimized.

@ThinkChaos

This comment has been minimized.

@jonas-schievink

This comment has been minimized.

@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 21, 2020
@ThinkChaos

This comment has been minimized.

@jonas-schievink

This comment has been minimized.

@JohnTitor JohnTitor added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Apr 21, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 3, 2020
…asKalbertodt

Add `RefCell::take`

Add `RefCell::take` to match `Cell` and `Option`.
I also changed a couple of calls to `.replace` to `.take`.

Tracking issue is rust-lang#71395.

This is my first contribution, please tell me if there's anything I could improve, thanks!
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 3, 2020
…asKalbertodt

Add `RefCell::take`

Add `RefCell::take` to match `Cell` and `Option`.
I also changed a couple of calls to `.replace` to `.take`.

Tracking issue is rust-lang#71395.

This is my first contribution, please tell me if there's anything I could improve, thanks!
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 3, 2020
…asKalbertodt

Add `RefCell::take`

Add `RefCell::take` to match `Cell` and `Option`.
I also changed a couple of calls to `.replace` to `.take`.

Tracking issue is rust-lang#71395.

This is my first contribution, please tell me if there's anything I could improve, thanks!
@KodrAus KodrAus added I-nominated Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. labels Jul 29, 2020
@KodrAus
Copy link
Contributor

KodrAus commented Oct 30, 2020

If anybody would like to open a stabilization PR for this we can kick off a FCP!

m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 22, 2020
…r=m-ou-se

Stabilize refcell_take

Tracking Issue: rust-lang#71395

`@KodrAus` nominated this for FCP, so here's a PR!
I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 22, 2020
…r=m-ou-se

Stabilize refcell_take

Tracking Issue: rust-lang#71395

``@KodrAus`` nominated this for FCP, so here's a PR!
I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.
@naiveai
Copy link

naiveai commented Dec 4, 2020

Think this issue should probably be closed, since it's now been stabilized!

twilco added a commit to twilco/accountable-refcell that referenced this issue Dec 11, 2020
This changeset also clarifies the language around mutable borrows.  The
message accountable_refcell paniced with when trying to take a mutable
borrow was not entirely accurate ("RefCell is already immutably borrowed"),
as panics can also occur when trying to mutably borrow a RefCell that is
already mutably borrowed.

Technically, at the time of this writing, the `take` method is not in
stable Rust, but will be in the next version (1.49) rust-lang/rust#71395

A rust-toolchain file has been added codifying the expectation that this
crate targets stable Rust.
twilco added a commit to twilco/accountable-refcell that referenced this issue Dec 11, 2020
This changeset also clarifies the language around mutable borrows.  The
message accountable_refcell paniced with when trying to take a mutable
borrow was not entirely accurate ("RefCell is already immutably borrowed"),
as panics can also occur when trying to mutably borrow a RefCell that is
already mutably borrowed.

Technically, at the time of this writing, the `take` method is not in
stable Rust, but will be in the next version (1.49) rust-lang/rust#71395

A rust-toolchain file has been added codifying the expectation that this
crate targets stable Rust.
twilco added a commit to twilco/accountable-refcell that referenced this issue Dec 11, 2020
This changeset also clarifies the language around mutable borrows.  The
message accountable_refcell paniced with when trying to take a mutable
borrow was not entirely accurate ("RefCell is already immutably borrowed"),
as panics can also occur when trying to mutably borrow a RefCell that is
already mutably borrowed.

Technically, at the time of this writing, the `take` method is not in
stable Rust, but will be in the next version (1.49) rust-lang/rust#71395

A rust-toolchain file has been added codifying the expectation that this
crate targets stable Rust.
jdm pushed a commit to jdm/accountable-refcell that referenced this issue Dec 11, 2020
This changeset also clarifies the language around mutable borrows.  The
message accountable_refcell paniced with when trying to take a mutable
borrow was not entirely accurate ("RefCell is already immutably borrowed"),
as panics can also occur when trying to mutably borrow a RefCell that is
already mutably borrowed.

Technically, at the time of this writing, the `take` method is not in
stable Rust, but will be in the next version (1.49) rust-lang/rust#71395

A rust-toolchain file has been added codifying the expectation that this
crate targets stable Rust.
sylvestre added a commit to sylvestre/coreutils that referenced this issue Jul 30, 2021
sylvestre added a commit to sylvestre/coreutils that referenced this issue Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants