Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused automatic cfg bindings #7169

Closed
brson opened this issue Jun 16, 2013 · 2 comments
Closed

Remove unused automatic cfg bindings #7169

brson opened this issue Jun 16, 2013 · 2 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 16, 2013

driver.rs has long defined a set of cfg bindings by default, but some of them are no longer used, or have never been used, target_libc, build_compiler, and build_input in particular.
@brson
Copy link
Contributor Author

brson commented Jun 16, 2013

Nominating backcompat.

@nickdesaulniers
Copy link

@brson , are those three the only ones that can be removed, or are there more? Specifically, which?

@bors bors closed this as completed in 0932ab3 Aug 15, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue May 6, 2021
@bors
Auto merge of rust-lang#7170 - flip1995:revert_drop_order, r=llogiq
182a185 
Fix stack overflow issue in `redundant_pattern_matching`

Fixes rust-lang#7169

~~cc `@Jarcho` Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.~~

r? `@llogiq`

changelog: none (fixes stack overflow, but this was introduced in this release cycle)
flip1995 pushed a commit to flip1995/rust that referenced this issue May 20, 2021
@bors @flip1995
Auto merge of rust-lang#7170 - flip1995:revert_drop_order, r=llogiq
98b11c8 
Fix stack overflow issue in `redundant_pattern_matching`

Fixes rust-lang#7169

~~cc `@Jarcho` Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.~~

r? `@llogiq`

changelog: none (fixes stack overflow, but this was introduced in this release cycle)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @nickdesaulniers