Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for feature arc_mutate_strong_count #71983

Closed
2 of 3 tasks
yoshuawuyts opened this issue May 7, 2020 · 2 comments · Fixed by #79285
Closed
2 of 3 tasks

Tracking Issue for feature arc_mutate_strong_count #71983

yoshuawuyts opened this issue May 7, 2020 · 2 comments · Fixed by #79285
Labels
A-concurrency Area: Concurrency related issues. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@yoshuawuyts
Copy link
Member

yoshuawuyts commented May 7, 2020 •
edited
Loading

The feature gate for the issue is #![feature(arc_mutate_strong_count)].

Steps

Unresolved Questions

  • Can we improve the docs phrasing on Arc::decr_strong_count?

Implementation history
@yoshuawuyts yoshuawuyts added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label May 7, 2020
@yoshuawuyts yoshuawuyts mentioned this issue May 7, 2020
Merged
@jonas-schievink jonas-schievink added A-concurrency Area: Concurrency related issues. B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 7, 2020
@vorner
Copy link
Contributor

vorner commented Jul 23, 2020

Hello

Would it make sense to also include similar methods for Rc? And possibly similar ones to both Weaks? It would be in part for the sake of completeness, but I do some manipulation like this in the arc-swap crate and if this would become the „official“ way, it would be nice to be supported on all the related types.

@KodrAus KodrAus added I-nominated Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. labels Jul 29, 2020
@yoshuawuyts yoshuawuyts mentioned this issue Nov 22, 2020
Merged
@yoshuawuyts
Copy link
Member Author

I think that's a great idea, and we should file follow-up issues to implement those.

@bors bors closed this as completed in ac37c32 Jan 31, 2021
@mystor mystor mentioned this issue Mar 25, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 7, 2021
@Dylan-DPC
Rollup merge of rust-lang#83476 - mystor:rc_mutate_strong_count, r=m-…
505846e 
…ou-se

Add strong_count mutation methods to Rc

The corresponding methods were stabilized on `Arc` in rust-lang#79285 (tracking: rust-lang#71983). This patch implements and stabilizes identical methods on the `Rc` types as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Concurrency related issues. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize Arc::{increment,decrement}_strong_count
5 participants
@m-ou-se @jonas-schievink @yoshuawuyts @KodrAus @vorner