-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc doesn't highlight "&&" properly #72684
Comments
jonas-schievink
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
May 28, 2020
@rustbot claim |
I don't think whitespace is preserved in token trees, indeed. :-/ |
We may not need whitespace information after all. We can just classify a token, emit any bytes from the source up to its first span, emit the opening HTML tag, emit the token, then the closing tag. Then do the same for all remaining tokens. |
Using token trees won't work because comments are not preserved. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…e27,GuillaumeGomez rustdoc: glue tokens before highlighting Fixes rust-lang#72684. This commit also modifies the signature of `Classifier::new` to avoid copying the source being highlighted.
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…e27,GuillaumeGomez rustdoc: glue tokens before highlighting Fixes rust-lang#72684. This commit also modifies the signature of `Classifier::new` to avoid copying the source being highlighted.
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…e27,GuillaumeGomez rustdoc: glue tokens before highlighting Fixes rust-lang#72684. This commit also modifies the signature of `Classifier::new` to avoid copying the source being highlighted.
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…e27,GuillaumeGomez rustdoc: glue tokens before highlighting Fixes rust-lang#72684. This commit also modifies the signature of `Classifier::new` to avoid copying the source being highlighted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried viewing this code with
rustdoc
:I expected to see this happen: the
&&
operator to be highlighted correctlyInstead, this happened:
Meta
rustc --version --verbose
: (issue also exists with nightly,2020-05-14
)This issue has been assigned to @euclio via this comment.
The text was updated successfully, but these errors were encountered: