Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clashing_extern_decl lint does not follow naming conventions #73802

Closed
nagisa opened this issue Jun 27, 2020 · 1 comment · Fixed by #73817
Closed

clashing_extern_decl lint does not follow naming conventions #73802

nagisa opened this issue Jun 27, 2020 · 1 comment · Fixed by #73817
Assignees
@rustbot
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nagisa
Copy link
Member

nagisa commented Jun 27, 2020 •
edited by rustbot
Loading

@petrochenkov said here:

The lint doesn't follow the lint naming conventions - https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints.

It should preferably be renamed clashing_extern_decl -> clashing_extern_declarations until it's on stable.

cc @jumbatm

This issue has been assigned to @jumbatm via this comment.
@nagisa nagisa added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Jun 27, 2020
@jumbatm
Copy link
Contributor

jumbatm commented Jun 27, 2020

@rustbot claim

@rustbot rustbot self-assigned this Jun 27, 2020
@jumbatm jumbatm mentioned this issue Jun 27, 2020
Merged
@bors bors closed this as completed in 8b92eec Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename clashing_extern_decl to clashing_extern_declarations. jumbatm/rust
3 participants
@nagisa @jumbatm @rustbot