-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't document compiler crates with --stage 0 #79980
Comments
@Mark-Simulacrum and I think this is the same root cause as #74976 (comment): |
Remove an unused dependency that made `rustdoc` crash Whilst struggling with rust-lang#79980 I discovered that this dependency was unused, and that made rustdoc crash. This PR removes it.
Noting that it seems #79540 should fix this! See the discussion on Zulip. |
@camelid well, it will still be broken if you don't have |
Has anything changed since this was last looked at to make this easier to fix? I'm running into this issue |
Fix `x doc --stage 0 compiler` Eric figured out the fix to this almost 2 years ago, I just didn't read his comment carefully enough at the timme. The issue was that fake rustc and fake rustdoc were inconsistent about when they passed `--sysroot` to the real compiler. Change them to consistently only pass it when `--target` is present. cc rust-lang#74976 (comment) Fixes rust-lang#79980 r? `@ehuss`
When I try to run
./x.py doc
withcompiler-docs = true
in config.toml, I get several errors. I started discussing this on Zulip. I am trying this on latestmaster
and a cleanbuild/
directory.First I got errors related to
-Znormalize-docs
. #79954 fixed those.Then I got a
'Unable to resolve external crate proc_macro2'
panic. #79984 fixed that.Finally I got this (even after clearing
build/
):And at that point I thought I'd open an issue because I have no idea what's happening.
EDIT: that error is the same as was found in #74976, which seemed to have vanished spontaneously(?).
EDIT: here's my
config.toml
without the comments:EDIT: tried with
incremental = false
and got the same errorThe text was updated successfully, but these errors were encountered: