Sanitizer support allow-list should not be baked into the compiler (outside of the built-in targets) #81802

nagisa · 2021-02-05T19:42:28Z

We have code such as this in our codebase that encodes an allow-list of targets that support for a given sanitizer:

rust/compiler/rustc_session/src/session.rs

Line 1541 in 5605b5d

const ASAN_SUPPORTED_TARGETS: &[&str] = &[

Instead, the code should be adjusted to only encode such support table in the target definitions. The compiler otherwise should be pretty agnostic to both the list of available sanitizers (outside of the backend) and targets that support it.

…get-prop, r=tmiasko Maintain supported sanitizers as a target property In an effort to remove a hard-coded allow-list for target-sanitizer support correspondence, this PR moves the configuration to the target options. Perhaps the one notable change made in this PR is this doc-comment: ```rust /// The sanitizers supported by this target /// /// Note that the support here is at a codegen level. If the machine code with sanitizer /// enabled can generated on this target, but the necessary supporting libraries are not /// distributed with the target, the sanitizer should still appear in this list for the target. ``` Previously the target would typically be added to the allow-list at the same time as the supporting runtime libraries are shipped for the target. However whether we ship the runtime libraries or not needn't be baked into the compiler; and if we don't users will receive a significantly more directed error about library not being found. Fixes rust-lang#81802

…t-prop, r=tmiasko Maintain supported sanitizers as a target property In an effort to remove a hard-coded allow-list for target-sanitizer support correspondence, this PR moves the configuration to the target options. Perhaps the one notable change made in this PR is this doc-comment: ```rust /// The sanitizers supported by this target /// /// Note that the support here is at a codegen level. If the machine code with sanitizer /// enabled can generated on this target, but the necessary supporting libraries are not /// distributed with the target, the sanitizer should still appear in this list for the target. ``` Previously the target would typically be added to the allow-list at the same time as the supporting runtime libraries are shipped for the target. However whether we ship the runtime libraries or not needn't be baked into the compiler; and if we don't users will receive a significantly more directed error about library not being found. Fixes rust-lang#81802

nagisa added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-sanitizers Area: Sanitizers for correctness and code quality. labels Feb 5, 2021

nagisa self-assigned this Feb 5, 2021

nagisa mentioned this issue Feb 7, 2021

Maintain supported sanitizers as a target property #81866

Merged

bors closed this as completed in 16c1d0a Apr 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sanitizer support allow-list should not be baked into the compiler (outside of the built-in targets) #81802

Sanitizer support allow-list should not be baked into the compiler (outside of the built-in targets) #81802

nagisa commented Feb 5, 2021

Sanitizer support allow-list should not be baked into the compiler (outside of the built-in targets) #81802

Sanitizer support allow-list should not be baked into the compiler (outside of the built-in targets) #81802

Comments

nagisa commented Feb 5, 2021