rustdoc JS does not handle NO_DEVICE_SPACE error

[lovasoa]

Problem

No documented item appear in documentation pages anywhere after a localStorage error.

(the page should render like that instead)

After localStorage raises a NS_ERROR_FILE_NO_DEVICE_SPACE error, all documentation page appear entirely blank. Freeing up space doesn't solve the isssue.

The following appears in the browser console :

Uncaught 
Exception
​
columnNumber: 0
​
data: null
​
filename: "https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js"
​
lineNumber: 1
​
message: ""
​
name: "NS_ERROR_FILE_NO_DEVICE_SPACE"
​
result: 2152857616
​
stack: "getCurrentValue@https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js:1:1802\ngetSettingValue@https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js:1:490\n@https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js:1:711\n"
​
<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
storage-20210124-1.51.0-nightly-1d0d76f8d.js:1
    getCurrentValue https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js:1
    getSettingValue https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js:1
    <anonymous> https://docs.rs/storage-20210124-1.51.0-nightly-1d0d76f8d.js:1

Steps

1. Fill the disk firefox uses for localStorage
2. open any documentation page on docs.rs : the documentation doesn't appear
3. Free up space
4. open any documentation page on docs.rs : the documentation still doesn't appear

Possible Solution(s)

Opening the docs in a private browsing window works.

[Eh2406]

Is this an issue with docs.rs, or with cargo doc or with an editor? Lets figure out which repo this report belongs in.

[lovasoa]

I think the problem is in the javascript generated by cargo doc which misses a try { ... } catch(e) { ... } statement around localStorage calls.

[lovasoa]

Where is the JavaScript source for the the cargo documentation ? Maybe I can attempt a PR myself?

[Eh2406]

The only reference to localStorage is in: https://github.com/rust-lang/rust/blob/c4e33b51c1a2d5e599b949fa3006467b88df253a/src/librustdoc/html/static/storage.js

[lovasoa]

Thanks !