Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg ignoring #[link(name="foo")] #8239

Closed
emberian opened this issue Aug 2, 2013 · 4 comments
Closed

rustpkg ignoring #[link(name="foo")] #8239

emberian opened this issue Aug 2, 2013 · 4 comments

Comments

@emberian
Copy link
Member

emberian commented Aug 2, 2013

There seems to be a bug where rustpkg ignores the #[link(name="foo")], both when building executables (for example, on rustdoc_ng it emits a "main" executable rather than "rustdoc_ng"), and installing (for rust-zmq, it tries to find librust_zmq-etc.so, even though it's built as libzmq)
@emberian
Copy link
Member Author

emberian commented Aug 3, 2013

With rustdoc_ng it seems to work fine now, but for rust-zmq it's still a problem

@ghost ghost assigned catamorphism Aug 3, 2013
@catamorphism
Copy link
Contributor

I suspect rustpkg is ignoring #[link(vers=3.1415927)] as well, and that really should work.

This also will need documentation once it's finished.

@catamorphism
Copy link
Contributor

@graydon thinks #[link(...)] should be removed altogether, so as to make it possible to refer to packages in extern mod directives. That change would require consensus, I guess.

@catamorphism
Copy link
Contributor

Closing in anticipation that #8523 will be accepted.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 17, 2022
@marekdownar
issue rust-lang#8239: Printed hint for lint or_fun_call is cropped an…
ee84ac3 
…d does not show the solution
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 17, 2022
@marekdownar
issue rust-lang#8239: fix to prev commit && 4 test cases
4950272
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 17, 2022
@bors
Auto merge of rust-lang#8292 - marekdownar:8239, r=xFrednet
8d14c94 
issue rust-lang#8239: Printed hint for lint or_fun_call is cropped and does no…

fixes rust-lang/rust-clippy#8239

changelog: [`or_fun_call`]: if suggestion contains more lines than MAX_SUGGESTION_HIGHLIGHT_LINES it is stripped to one line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catamorphism @emberian