Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc: glob reexport may duplicate module #83375

Closed
WaffleLapkin opened this issue Mar 22, 2021 · 2 comments · Fixed by #101631 or ruma/ruma#1288
Closed

Rustdoc: glob reexport may duplicate module #83375

WaffleLapkin opened this issue Mar 22, 2021 · 2 comments · Fixed by #101631 or ruma/ruma#1288
Assignees
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Mar 22, 2021

If glob reexport reexports module x and there is already module x, the documentation duplicates.

pub mod sub {
    pub struct Item;

    pub mod prelude {
        pub use super::Item;
    }    
}

pub mod prelude {}

#[doc(inline)]
pub use sub::*;

Current behaviour:

image

(prelude module is duplicated, though both prelude module links point to crate::prelude as expected)

The expected behaviour: prelude module is only shown once.

@WaffleLapkin WaffleLapkin added the C-bug Category: This is a bug. label Mar 22, 2021
@jonas-schievink jonas-schievink added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 22, 2021
@longfangsong
Copy link
Contributor

@rustbot claim

@aliemjay
Copy link
Member

aliemjay commented Sep 7, 2021

@rustbot claim

@rustbot rustbot assigned aliemjay and unassigned longfangsong Sep 7, 2021
@notriddle notriddle assigned notriddle and unassigned aliemjay Sep 9, 2022
@bors bors closed this as completed in 6afbe3e Sep 10, 2022
jplatte added a commit to ruma/ruma that referenced this issue Sep 21, 2022
Previously this would result in rustdoc showing two `api` modules, but
that is now fixed: rust-lang/rust#83375
jplatte added a commit to ruma/ruma that referenced this issue Sep 21, 2022
Previously this would result in rustdoc showing two `api` modules, but
that is now fixed: rust-lang/rust#83375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
6 participants