Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE: wrong const argument causes a couple of ICE #83466

Closed
JohnTitor opened this issue Mar 25, 2021 · 4 comments · Fixed by #84410
Closed

ICE: wrong const argument causes a couple of ICE #83466

JohnTitor opened this issue Mar 25, 2021 · 4 comments · Fixed by #84410
Assignees
@BoxyUwU
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. glacier ICE tracked in rust-lang/glacier. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@JohnTitor
Copy link
Member

JohnTitor commented Mar 25, 2021 •
edited by rustbot
Loading

This is ICE since 1.50.0, error -> ICE.

playground

struct S;
impl S {
    fn func<'a, U>(self) -> U {
        todo!()
    }
}
fn dont_crash<'a, U>() {
    S.func::<'a, dont_crash>()
}

fn main() {}

Originally posted by @chengniansun in #82792 (comment)
@JohnTitor JohnTitor added C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2021
@jonas-schievink jonas-schievink added A-const-generics Area: const generics (parameters and arguments) I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Mar 25, 2021
@JohnTitor JohnTitor added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Mar 25, 2021
@hameerabbasi
Copy link
Contributor

Bisected:

searched nightlies: from nightly-2020-01-01 to nightly-2021-03-17
regressed nightly: nightly-2020-11-18
searched commits: from f5230fb to c919f49
regressed commit: c6a6105

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc --test-dir=. --start=2020-01-01 --regress=ice

@JohnTitor
Copy link
Member Author

Thanks for bisecting, @hameerabbasi! I believe #79032 is the cause.

fanninpm added a commit to fanninpm/glacier that referenced this issue Mar 26, 2021
@fanninpm
Add 83466
0784825 
Issue: rust-lang/rust#83466
@lcnr
Copy link
Contributor

lcnr commented Mar 26, 2021

Assigning P-medium and removing I-prioritize as discussed in the prioritization working group.

@rustbot label: +P-medium -I-prioritize

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Mar 26, 2021
@rust-lang-glacier-bot rust-lang-glacier-bot added the glacier ICE tracked in rust-lang/glacier. label Mar 27, 2021
@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 21, 2021

@rustbot claim

@BoxyUwU BoxyUwU mentioned this issue Apr 21, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 1, 2021
@Dylan-DPC
Rollup merge of rust-lang#84410 - BoxyUwU:blue, r=varkor
637b1e9 
Fix generic arg mismatch errors being ignored with explicit late bound lifetimes

Fixes rust-lang#83466

r? `@varkor`
@bors bors closed this as completed in 4de7572 May 1, 2021
@github-actions github-actions bot mentioned this issue May 2, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoxyUwU BoxyUwU

Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. glacier ICE tracked in rust-lang/glacier. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix generic arg mismatch errors being ignored with explicit late bound lifetimes BoxyUwU/rust
7 participants
@jonas-schievink @hameerabbasi @BoxyUwU @JohnTitor @lcnr @rustbot @rust-lang-glacier-bot