Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate symbol error when building with -Zinstrument-coverage #84604

Closed
AdrianDanis opened this issue Apr 27, 2021 · 1 comment · Fixed by #84682
Closed

Duplicate symbol error when building with -Zinstrument-coverage #84604

AdrianDanis opened this issue Apr 27, 2021 · 1 comment · Fixed by #84682
Labels
C-bug Category: This is a bug.

Comments

@AdrianDanis
Copy link

We are getting a duplicate symbol build error when compiling with -Zinstrument-coverage. The error itself is

error: symbol `_RINvMs_NtCs4sOTlpwc4M4_4core3fmtNtB5_10ArgumentV13newINtNtCscPVYfkHMOef_5alloc5boxed3BoxDINtNtCs7fMeNustxns_15predicates_core4core9PredicateeENtNtB7_6marker4SendEL_EECshGpAVYOtgW1_12ffx_emulator` is already defined

(Full build here with a RUST_BACKTRACE)

The demangled symbol is <core::fmt::ArgumentV1>::new::<alloc::boxed::Box<dyn predicates_core::core::Predicate<str> + core::marker::Send>>

That type referenced is from the predicates_core public crate, but unfortunately we have not yet narrowed down a reproduction beyond doing the full build.

Believe this to be related to #83737 (specifically this comment)
cc: @jackh726

@AdrianDanis AdrianDanis added the C-bug Category: This is a bug. label Apr 27, 2021
@AdrianDanis
Copy link
Author

Although there's nothing that looks like a cause, the actual code change that triggered the build failure was https://fuchsia-review.googlesource.com/c/fuchsia/+/514541/

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 29, 2021
Add HAS_RE_LATE_BOUND if there are bound vars

Fixes rust-lang#83737
Fixes rust-lang#84604

I can rename `HAS_RE_LATE_BOUND`, to something like `HAS_LATE_BOUND_VARS`.

r? `@nikomatsakis`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 29, 2021
Add HAS_RE_LATE_BOUND if there are bound vars

Fixes rust-lang#83737
Fixes rust-lang#84604

I can rename `HAS_RE_LATE_BOUND`, to something like `HAS_LATE_BOUND_VARS`.

r? ``@nikomatsakis``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 29, 2021
Add HAS_RE_LATE_BOUND if there are bound vars

Fixes rust-lang#83737
Fixes rust-lang#84604

I can rename `HAS_RE_LATE_BOUND`, to something like `HAS_LATE_BOUND_VARS`.

r? ```@nikomatsakis```
jackh726 added a commit to jackh726/rust that referenced this issue Apr 29, 2021
…r=nikomatsakis

Don't rebind in `transitive_bounds_that_define_assoc_type`

Fixes rust-lang#83737
Fixes rust-lang#84604

Also fixes another issue that I don't have a test for, popped up in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Duplicate.20symbol.20error.20.2384604/near/236570445)

r? `@nikomatsakis`
jackh726 added a commit to jackh726/rust that referenced this issue Apr 29, 2021
…r=nikomatsakis

Don't rebind in `transitive_bounds_that_define_assoc_type`

Fixes rust-lang#83737
Fixes rust-lang#84604

Also fixes another issue that I don't have a test for, popped up in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Duplicate.20symbol.20error.20.2384604/near/236570445)

r? ``@nikomatsakis``
jackh726 added a commit to jackh726/rust that referenced this issue Apr 29, 2021
…r=nikomatsakis

Don't rebind in `transitive_bounds_that_define_assoc_type`

Fixes rust-lang#83737
Fixes rust-lang#84604

Also fixes another issue that I don't have a test for, popped up in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Duplicate.20symbol.20error.20.2384604/near/236570445)

r? ```@nikomatsakis```
jackh726 added a commit to jackh726/rust that referenced this issue Apr 29, 2021
…r=nikomatsakis

Don't rebind in `transitive_bounds_that_define_assoc_type`

Fixes rust-lang#83737
Fixes rust-lang#84604

Also fixes another issue that I don't have a test for, popped up in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Duplicate.20symbol.20error.20.2384604/near/236570445)

r? ````@nikomatsakis````
@bors bors closed this as completed in 26a4f46 Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
1 participant