Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move header CSS classes (such as "method"/"function"/etc) from h3/h4 into their parent #84829

Closed
GuillaumeGomez opened this issue May 2, 2021 · 0 comments · Fixed by #85169
Closed

Move header CSS classes (such as "method"/"function"/etc) from h3/h4 into their parent #84829

GuillaumeGomez opened this issue May 2, 2021 · 0 comments · Fixed by #85169
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

This issue comes from this discussion. Moving the CSS classes into the <summary> parent or into the <details> grand-parent would allow to simplify the JS handling and keep the HTML size the same.

To be discussed when @jsha when he's back. :)
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels May 2, 2021
@jsha jsha mentioned this issue May 11, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 19, 2021
@Dylan-DPC
Rollup merge of rust-lang#85169 - jsha:hoist-classes, r=GuillaumeGomez
d466302 
Add method-toggle to <details> for methods

The makes the code for handling "auto-hide" settings more consistent.

Demo at https://hoffman-andrews.com/rust/hoist-classes/std/string/struct.String.html

Fixes rust-lang#84829
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 19, 2021
@Dylan-DPC
Rollup merge of rust-lang#85169 - jsha:hoist-classes, r=GuillaumeGomez
7a67602 
Add method-toggle to <details> for methods

The makes the code for handling "auto-hide" settings more consistent.

Demo at https://hoffman-andrews.com/rust/hoist-classes/std/string/struct.String.html

Fixes rust-lang#84829
@bors bors closed this as completed in 4217430 May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add method-toggle to <details> for methods jsha/rust
1 participant
@GuillaumeGomez