-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust deprecated suggestion is wrong for mod #85403
Comments
Is this a typo?
Because I want to bring the number of the issue. let me try to make it work for modules and inner functions. @rustbot claim |
Not sure what you are refering to. To the |
I see. No typo. Thanks! |
shrinking the deprecated method span part of rust-lang#85403 r? `@estebank`
shrinking the deprecated method span part of rust-lang#85403 r? `@estebank`
…tebank shrinking the deprecated span ref: rust-lang#85617 (comment) part of rust-lang#85403 r? `@estebank` The reason is that if we use method_span directly, it will cause the in_derive_expansion judgment to fail.
|
This is an extension of #84637
First and foremost, thank you @hi-rustin for fixing the original issue in #85018.
Just a quick question: Why did you create a new file instead of extending the existing one?
While the code perfectly works for associated functions, it does not work for modules and inner functions.
Given the following code: (Playground)
The current output is:
Ideally the output should look like:
Please note that it still says deprecated function. I'm not entirely sure if
rustc_deprecated
is allowed on modules, but I guess so.I think it should say:
The text was updated successfully, but these errors were encountered: