Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-builtins test no longer passing on ppc64le #88520

Open
nbdd0121 opened this issue Aug 31, 2021 · 2 comments
Open

compiler-builtins test no longer passing on ppc64le #88520

nbdd0121 opened this issue Aug 31, 2021 · 2 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-bug Category: This is a bug. O-PowerPC Target: PowerPC processors T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nbdd0121
Copy link
Contributor

The current HEAD of compiler-builtin's master branch no longer passes CI tests. Error reports failing at testcrate/tests/cmp.rs:34:9 for powerpc64le-unknown-linux-gnu target.

Bisection shows that the test still builds in nightly-2021-08-21 but fails in nightly-2021-08-22, so I suspect the issue is from LLVM upgrade #87570.

Initially discovered in rust-lang/compiler-builtins#405.
@nbdd0121 nbdd0121 added the C-bug Category: This is a bug. label Aug 31, 2021
@jyn514 jyn514 added O-PowerPC Target: PowerPC processors A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. labels Aug 31, 2021
Amanieu added a commit to Amanieu/rustc-builtins that referenced this issue Oct 14, 2021
@Amanieu
Disable broken powerpc64 test due to rust-lang/rust#88520
b6c683f
@Amanieu Amanieu mentioned this issue Oct 14, 2021
Merged
Amanieu added a commit to Amanieu/rustc-builtins that referenced this issue Oct 15, 2021
@Amanieu
Disable broken powerpc64 test due to rust-lang/rust#88520
7a940af
Amanieu added a commit to Amanieu/rustc-builtins that referenced this issue Oct 15, 2021
@Amanieu
Disable broken powerpc64 test due to rust-lang/rust#88520
cf94e8e
Amanieu added a commit to Amanieu/rustc-builtins that referenced this issue Oct 15, 2021
@Amanieu
Disable broken powerpc64 test due to rust-lang/rust#88520
55f6ecb
vladimir-ea pushed a commit to vladimir-ea/compiler-builtins that referenced this issue Mar 8, 2022
@Amanieu @vladimir-ea
Disable broken powerpc64 test due to rust-lang/rust#88520
d214b58
@workingjubilee workingjubilee changed the title compiler-builtins test no longer passing compiler-builtins test no longer passing on ppc64le Jul 22, 2022
@Amanieu Amanieu mentioned this issue Jul 28, 2022
Open
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 3, 2022
@apiraino apiraino mentioned this issue Sep 1, 2022
Open
@tgross35
Copy link
Contributor

Any idea if this still a problem? There are a handful of functions in libm that were skipped with a link to this issue, but I have seemingly been able to enable them again.

@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2025

The issues were likely caused by LLVM so if it works now then it most likely has been fixed in the latest LLVM upgrade. If it passes CI then it's fine to just re-enable these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-bug Category: This is a bug. O-PowerPC Target: PowerPC processors T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Amanieu @nbdd0121 @apiraino @tgross35 @jyn514