Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document additional differences in SystemTime across platforms #88822

Closed
rylev opened this issue Sep 10, 2021 · 0 comments · Fixed by #93462
Closed

Document additional differences in SystemTime across platforms #88822

rylev opened this issue Sep 10, 2021 · 0 comments · Fixed by #93462
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools O-windows Operating system: Windows

Comments

@rylev
Copy link
Member

rylev commented Sep 10, 2021

In rust-lang/measureme#173 we discovered that our tests were failing on Windows because SystemTime on Windows (which is backed by FILETIME) only works in 100 nanosecond intervals, and when we were adding a Duration of less than 100 nanoseconds to a SystemTime we were getting back the same SystemTime.

While this isn't a bug as SystemTime makes it clear that it uses platform specific backing implementations, it would be nice if it were documented that some of the operations on SystemTime might perform differently on different platforms.
@rylev rylev added O-windows Operating system: Windows A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Sep 10, 2021
@ChrisDenton ChrisDenton mentioned this issue Jan 29, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 30, 2022
@matthiaskrgr
Rollup merge of rust-lang#93462 - ChrisDenton:systime-doc, r=joshtrip…
ed50b23 
…lett

Document `SystemTime` platform precision

Fixes rust-lang#88822
@bors bors closed this as completed in bc2c4fe Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document SystemTime platform precision ChrisDenton/rust
1 participant
@rylev