Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for cfg_target_has_atomic_equal_alignment #93822

Open
Amanieu opened this issue Feb 9, 2022 · 0 comments
Open

Tracking Issue for cfg_target_has_atomic_equal_alignment #93822

Amanieu opened this issue Feb 9, 2022 · 0 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-design-concerns Status: There are blocking design concerns. S-tracking-needs-to-bake Status: The implementation is "complete" but it needs time to bake. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@Amanieu
Copy link
Member

Amanieu commented Feb 9, 2022 •
edited by Mark-Simulacrum
Loading

This is a tracking issue for the target_has_atomic_equal_alignment CFG flag which was added in #76965 for Atomic*::from_mut.

It indicates whether an AtomicX has the same alignment as the equivalent X integer type. On some 32-bit platforms (e.g. x86) AtomicI64 has an alignment of 8 while i64 is only aligned to 4 bytes.

Potential design concerns:

  • Open question of whether a dedicated cfg is necessary over cfg(accessible) on the from_mut method specifically, which is what is currently gated on this cfg
@Amanieu Amanieu added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Feb 9, 2022
This was referenced Feb 9, 2022
Closed
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#93824 - Amanieu:stable_cfg_target_has_atomi…
aa20959 
…c, r=davidtwco

Stabilize cfg_target_has_atomic

`target_has_atomic_equal_alignment` is now tracked separately in rust-lang#93822.

Closes rust-lang#32976
@Mark-Simulacrum Mark-Simulacrum added S-tracking-design-concerns Status: There are blocking design concerns. S-tracking-needs-to-bake Status: The implementation is "complete" but it needs time to bake. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Feb 16, 2022
@carols10cents carols10cents mentioned this issue Nov 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-design-concerns Status: There are blocking design concerns. S-tracking-needs-to-bake Status: The implementation is "complete" but it needs time to bake. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amanieu @Mark-Simulacrum