Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in URL to 1.58.1 release notes in announcement blog post #94278

Closed
paulmenzel opened this issue Feb 23, 2022 · 2 comments · Fixed by #111621
Closed

Typo in URL to 1.58.1 release notes in announcement blog post #94278

paulmenzel opened this issue Feb 23, 2022 · 2 comments · Fixed by #111621
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@paulmenzel
Copy link

The URL to the 1.58.1 release notes in the blog post Announcing Rust 1.58.1 is incorrect. Instead of

https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1581-2022-01-20

it should be

https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1581-2022-01-19
@Urgau
Copy link
Member

Urgau commented Feb 23, 2022

Well now it should be: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1590-2022-02-24

The is also a rendering issue with unreachable! not being a link due to an incorrect markdown:

cc @Mark-Simulacrum (for the release team)

@Mark-Simulacrum
Copy link
Member

Since the announcement was made on the 20th, it probably makes sense to edit the release notes instead of the blog post.

The compatibility notes would indeed be nice to adjust, but I'm not likely to have another stable build in the next ~24 hours before a release, so we'll leave that for an upcoming forward-port to master.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Feb 23, 2022
Closed
@Urgau Urgau mentioned this issue Feb 24, 2022
Closed
@jyn514 jyn514 added C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Apr 9, 2023
@ehuss ehuss mentioned this issue May 15, 2023
Merged
Noratrieb added a commit to Noratrieb/rust that referenced this issue May 16, 2023
@Noratrieb
Rollup merge of rust-lang#111621 - ehuss:relnotes-1.58.1-date, r=Mark…
882e061 
…-Simulacrum

Fix release date of 1.58.1 in release notes.

This fixes the release notes to have the correct release date for 1.58.1. The [blog announcement](https://blog.rust-lang.org/2022/01/20/Rust-1.58.1.html) has the correct date and link (which is otherwise broken without this change).

Closes rust-lang#94278
Noratrieb added a commit to Noratrieb/rust that referenced this issue May 16, 2023
@Noratrieb
Rollup merge of rust-lang#111621 - ehuss:relnotes-1.58.1-date, r=Mark…
74b6395 
…-Simulacrum

Fix release date of 1.58.1 in release notes.

This fixes the release notes to have the correct release date for 1.58.1. The [blog announcement](https://blog.rust-lang.org/2022/01/20/Rust-1.58.1.html) has the correct date and link (which is otherwise broken without this change).

Closes rust-lang#94278
@bors bors closed this as completed in 5c0b8f1 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix release date of 1.58.1 in release notes. ehuss/rust
4 participants
@Urgau @Mark-Simulacrum @paulmenzel @jyn514