makefile: define as many make variables as possible before use #9547
Comments
|
part of #8058 |
|
This appears to have gotten significantly worse: https://gist.github.com/huonw/bc37c9b56bd3a51450c1 (the |
|
Triage: no change. There's a lot of these, and it's hard to tell what to do with them. |
|
Make's now gone, so closing. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 6, 2022
fallout: fix tests to allow uninlined_format_args In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones See also rust-lang/rust-clippy#9233, rust-lang/rust-clippy#9525, rust-lang/rust-clippy#9527 cc: `@llogiq` `@Alexendoo` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A bug (#9531) went undetected because I was careless and failed to put a variable definition before all of its uses (SHA: b1a2251).
Further investigation revealed that make does offer an
--warn-undefined-variablesoption that will list all variables that are expanded without being provided a definition.It might be good if we tried to minimize the number of warnings emitted by that flag, by putting explicit (even if empty) definitions up before their first use.
(Here's the list of warnings emitted, with obvious duplicate entries removed.)
The text was updated successfully, but these errors were encountered: