Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty impl obsolete syntax error is wrong #9561

Closed
metajack opened this issue Sep 27, 2013 · 2 comments
Closed

empty impl obsolete syntax error is wrong #9561

metajack opened this issue Sep 27, 2013 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@metajack
Copy link
Contributor

impl Foo for Bar;
fails with
error: obsolete syntax: empty implementation
and the span points to the next item not the empty impl.

Why not specifically say what the new syntax is?

cc @alexcrichton

@alexcrichton
Copy link
Member

The span should actually get fixed by #9525 (sorry about that!), but there should be a NOTE accompanying the error saying why, are you not seeing the note?

@alexcrichton
Copy link
Member

This obsolete printing has since been removed.

flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 6, 2022
rustc_tool_utils: bump version in anticipation of a new release

cc rust-lang/rust-clippy#9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.

reopen of rust-lang#9561

changelog: release `rustc_tools_util` on `Crates.io`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Development

No branches or pull requests

3 participants