a function!() macro like C99's __func__ would be useful in addition to file!() and line!() #9586
Labels
A-syntaxext
Area: Syntax extensions
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
Comments
|
Triage: This has been formally proposed in rust-lang/rfcs#466 |
|
Closing in favor of RFC issue. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 6, 2022
…earth
FormatArgsExpn: Find comma spans and ignore weird proc macro spans
Fixes the following cases:
A missing `, 1` from the `expect_fun_call` suggestion:
```rust
Some(()).expect(&format!("{x} {}", 1));
```
```
warning: use of `expect` followed by a function call
--> t.rs:7:14
|
7 | Some(()).expect(&format!("{x} {}", 1));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{x} {}"))`
```
The suggestion removing from the comma in the comment rather than the one after the format string:
```rust
println!(
"{}",
// a comment, with a comma in it
x
);
```
```
warning: variables can be used directly in the `format!` string
--> t.rs:9:5
|
9 | / println!(
10 | | "{}",
11 | | // a comment, with a comma in it
12 | | x
13 | | );
| |_____^
|
help: change this to
|
10 ~ "{x}",
11 ~ // a comment
|
```
It also no longer accepts expansions where a format string or argument has a "weird" proc macro span, that is one where the literal/expression it outputs has the span of one of its inputs. Kind of like a `format_args` specific `clippy_utils::is_from_proc_macro`, e.g. `format!(indoc! {" ... "})`
changelog: [`expect_fun_call`]: Fix suggestion for `format!` using captured variables
changelog: [`print_literal`], [`write_literal`], [`uninlined_format_args`]: Fix suggestion when following a comment including a comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the title says it all; especially if there is good information in the function name, being able to know the function name inside another macro would be quite useful.
The text was updated successfully, but these errors were encountered: