Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.exe reports x.py not found when python isn't found #99648

Closed
ChrisDenton opened this issue Jul 23, 2022 · 3 comments · Fixed by #100020
Closed

x.exe reports x.py not found when python isn't found #99648

ChrisDenton opened this issue Jul 23, 2022 · 3 comments · Fixed by #100020
Assignees
@callumio
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ChrisDenton
Copy link
Member

ChrisDenton commented Jul 23, 2022 •
edited by rustbot
Loading

I was playing with a dev server config and forgot to put python in PATH, leading to a confusing error message:

PS C:\Users\Chris\rust\rust> x dist
Failed to invoke `C:\Users\Chris\rust\rust\x.py`: program not found
x.py not found. Please run inside of a checkout of `https://github.com/rust-lang/rust`.
PS C:\Users\Chris\rust\rust> ls

    Directory: C:\Users\Chris\rust\rust

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----           7/23/2022  1:50 PM                .github
d----           7/23/2022  2:27 PM                build
d----           7/23/2022  1:50 PM                compiler
d----           7/23/2022  1:50 PM                library
d----           7/23/2022  1:52 PM                src
-a---           7/23/2022  1:50 PM            417 .editorconfig
-a---           7/23/2022  1:50 PM            187 .git-blame-ignore-revs
-a---           7/23/2022  1:50 PM            464 .gitattributes
-a---           7/23/2022  1:50 PM           1251 .gitignore
-a---           7/23/2022  1:50 PM           1684 .gitmodules
-a---           7/23/2022  1:50 PM          28418 .mailmap
-a---           7/23/2022  1:52 PM         129410 Cargo.lock
-a---           7/23/2022  1:50 PM           5059 Cargo.toml
-a---           7/23/2022  1:50 PM            131 CODE_OF_CONDUCT.md
-a---           7/23/2022  2:27 PM            101 config.toml
-a---           7/23/2022  1:50 PM          32437 config.toml.example
-a---           7/23/2022  1:50 PM            292 configure
-a---           7/23/2022  1:50 PM           2415 CONTRIBUTING.md
-a---           7/23/2022  1:50 PM           9322 COPYRIGHT
-a---           7/23/2022  1:50 PM           9723 LICENSE-APACHE
-a---           7/23/2022  1:50 PM           1023 LICENSE-MIT
-a---           7/23/2022  1:50 PM          10308 README.md
-a---           7/23/2022  1:50 PM         582886 RELEASES.md
-a---           7/23/2022  1:50 PM           1307 rustfmt.toml
-a---           7/23/2022  1:51 PM           9504 triagebot.toml
-a---           7/23/2022  1:51 PM           1531 x.py
@ChrisDenton ChrisDenton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 23, 2022
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints labels Jul 24, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 24, 2022

Mentoring instructions: change src/tools/x to have a better error in this case.

@ChrisDenton note you'll have to manually reinstall it once that's done; we don't currently have an upgrade path for that tool which is one of the reasons we're planning to use shell scripts in #94829

@jyn514 jyn514 added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Jul 24, 2022
@reez12g
Copy link
Contributor

reez12g commented Jul 24, 2022

@rustbot claim

@callumio
Copy link
Contributor

callumio commented Aug 1, 2022

@rustbot claim

@rustbot rustbot assigned callumio and unassigned reez12g Aug 1, 2022
@callumio callumio mentioned this issue Aug 1, 2022
Merged
@matthiaskrgr matthiaskrgr mentioned this issue Aug 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 1, 2022
@bors
Auto merge of rust-lang#100024 - matthiaskrgr:rollup-36ab4wx, r=matth…
c9e134e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99340 (Fix ICE in Definitions::create_def)
 - rust-lang#99629 (Improve `cannot move out of` error message)
 - rust-lang#99864 (bootstrap: don't emit warn about duplicated deps with same/different features if some of sets actually empty)
 - rust-lang#99911 (Remove some uses of `guess_head_span`)
 - rust-lang#99976 (Make Rustdoc exit with correct error code when scraping examples from invalid files)
 - rust-lang#100003 (Improve size assertions.)
 - rust-lang#100012 (Avoid `Ty` to `String` conversions)
 - rust-lang#100020 (better error when python is not found in x - issue rust-lang#99648)

Failed merges:

 - rust-lang#99994 (Replace `guess_head_span` with `opt_span`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors closed this as completed in 058ea7a Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callumio callumio

Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better error when python is not found in x - issue #99648 callumio/rust
4 participants
@ChrisDenton @callumio @jyn514 @reez12g