Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize thread ID generation #100022

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Optimize thread ID generation #100022

merged 1 commit into from
Aug 12, 2022

Conversation

joboet
Copy link
Member

@joboet joboet commented Aug 1, 2022

By using atomics where available, thread IDs can be generated without locking while still enforcing uniqueness.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2022
@5225225
Copy link
Contributor

5225225 commented Aug 1, 2022 •
edited
Loading

edit: I didn't read the code carefully enough! sorry!

@joboet
Copy link
Member Author

joboet commented Aug 3, 2022

edit: I didn't read the code carefully enough! sorry!

No worries! GitHub somehow has problems displaying the diff; I found it hard to read even though I wrote it 😉!

@joshtriplett
Copy link
Member

LGTM; r=me with the suggestion applied.

@joboet
Copy link
Member Author

joboet commented Aug 10, 2022

@joshtriplett Done! Should I squash commits?

@joshtriplett
Copy link
Member

@joboet Yes, please do.

@joshtriplett
Copy link
Member

@bors delegate+

@bors
Copy link
Contributor

bors commented Aug 10, 2022

✌️ @joboet can now approve this pull request

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 10, 2022

📌 Commit 3d21c37 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2022
@bors
Auto merge of rust-lang#100456 - Dylan-DPC:rollup-fn17z9f, r=Dylan-DPC
f22819b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#100022 (Optimize thread ID generation)
 - rust-lang#100030 (cleanup code w/ pointers in std a little)
 - rust-lang#100229 (add -Zextra-const-ub-checks to enable more UB checking in const-eval)
 - rust-lang#100247 (Generalize trait object generic param check to aliases.)
 - rust-lang#100255 (Adding more verbose documentation for `std::fmt::Write`)
 - rust-lang#100366 (errors: don't fail on broken primary translations)
 - rust-lang#100396 (Suggest const and static for global variable)
 - rust-lang#100409 (rustdoc: don't generate DOM element for operator)
 - rust-lang#100443 (Add two let else regression tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a8c799a into rust-lang:master Aug 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 12, 2022
@joboet joboet deleted the faster_threadid branch August 12, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@joboet @rustbot @rust-highfive @5225225 @joshtriplett @bors @kennytm