Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend comma suggestion to cases where fields arent missing #100309

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Extend comma suggestion to cases where fields arent missing #100309

merged 1 commit into from
Aug 23, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #100300

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 9, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@sanxiyn
Copy link
Member

sanxiyn commented Aug 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2022

📌 Commit f4bf8cd has been approved by sanxiyn

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2022
@bors
Auto merge of rust-lang#100920 - Dylan-DPC:rollup-vlcw3sr, r=Dylan-DPC
a1bea15 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#99249 (Do not re-parse function signatures to suggest generics)
 - rust-lang#100309 (Extend comma suggestion to cases where fields arent missing)
 - rust-lang#100368 (InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed>)
 - rust-lang#100768 (Migrate `rustc_plugin_impl` to `SessionDiagnostic`)
 - rust-lang#100835 (net listen backlog update, follow-up from rust-lang#97963.)
 - rust-lang#100851 (Fix rustc_parse_format precision & width spans)
 - rust-lang#100857 (Refactor query modifier parsing)
 - rust-lang#100907 (Fix typo in UnreachableProp)
 - rust-lang#100909 (Minor `ast::LitKind` improvements)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8733550 into rust-lang:master Aug 23, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 23, 2022
@Havvy
Copy link
Contributor

Havvy commented Aug 24, 2022

Work has been a mess for me lately leaving me no energy. I'm reassigning to @ehuss ; You can ignore my requested changes marker. I don't know how to remove it.

Also, I raised this in Zulip and there was a small discussion on it: https://rust-lang.zulipchat.com/#narrow/stream/237824-t-lang.2Fdoc/topic/Methods.20taking.20self.20by.20value.20explicitly.20dispatchable.3F

@compiler-errors compiler-errors deleted the issue-100300 branch August 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Suggest missing comma on last field before struct update syntax
7 participants
@compiler-errors @rust-highfive @sanxiyn @bors @Havvy @oli-obk @rustbot