Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont ICE when encountering indeterminate paths in rustdoc #100310

Closed

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 9, 2022

Not sure if we can avoid having indeterminate paths due to the way that we handle globs (see test), so just suppress the ICE here.

Fixes #100241


Note: The UI test I provided is literally wrong, I don't know how to make a rustdoc test distinguish ICE (bad) and regular fail (good), since we don't have any sort of granularity in failure mode except for // should-fail, which triggers any time rustdoc fails at all.

Perhaps someone knows how to fix this at the compiletest level?

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 9, 2022
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@petrochenkov petrochenkov self-assigned this Aug 9, 2022
@petrochenkov
Copy link
Contributor

PathResult::Indeterminate shouldn't appear there, there must be some other underlying issue.

@petrochenkov
Copy link
Contributor

It would be better to find where this PathResult::Indeterminate is created and fix the underlying issue instead of hiding it.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2022
@compiler-errors
Copy link
Member Author

Yup, I can do that. The minimized example is pretty small, so doesn't seem too impossible.

@bors
Copy link
Contributor

bors commented Oct 11, 2022

☔ The latest upstream changes (presumably #102926) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

Superseded by #103096.

@compiler-errors compiler-errors deleted the issue-100241 branch August 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE in rustdoc: internal error: entered unreachable code
7 participants