-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize instance substs during legacy symbol mangling #100312
Closed
compiler-errors
wants to merge
1
commit into
rust-lang:master
from
compiler-errors:normalize-consts-in-mangle
Closed
Normalize instance substs during legacy symbol mangling #100312
compiler-errors
wants to merge
1
commit into
rust-lang:master
from
compiler-errors:normalize-consts-in-mangle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Aug 9, 2022
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 9, 2022
Ugh, debug assertions. @rustbot author |
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 9, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
Actually, this is the wrong approach I think. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2022
Keep going if normalized projection has unevaluated consts in `QueryNormalizer` rust-lang#100312 was the wrong approach, I think this is the right one. When normalizing a type, if we see that it's a projection, we currently defer to `tcx.normalize_projection_ty`, which normalizes the projections away but doesn't touch the unevaluated constants. So now we just continue to fold the type if it has unevaluated constants so we make sure to evaluate those too, if we can. Fixes rust-lang#100217 Fixes rust-lang#83972 Fixes rust-lang#84669 Fixes rust-lang#86710 Fixes rust-lang#82268 Fixes rust-lang#73298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already normalize in the v0 mangling scheme, and this shouldn't have an effect on non-
generic_const_expr
code, since normalization should be idempotent in any other case, though I can gate it behind that feature if desired if there's perceived risk.Open to alternative approaches, such as tracking down where these unnormalized const substs are actually coming from.
Fixes #100217
Fixes #83972
Fixes #84669
Fixes #86710
Fixes #82268
Fixes #73298