Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdarch submodule #100911

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Update stdarch submodule #100911

merged 3 commits into from
Aug 25, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Aug 23, 2022

Changes from stdarch:

  • Fix links in documentation of cmpxchg16b
  • Use load intrinsic and loop for intrinsic-test programs. Add --release flag back to intrinsic-test programs.
  • Properly fix vext intrinsic tests
  • Replace some calls to pointer::offset with add and sub
  • Allow internal use of stdsimd from detect_feature
  • fix target name in contributing.md
  • Tweak constant for ARM vext instruction tests
  • Use llvm.ppc.altivec.lvx intrinsic for vec_ld
  • Adding doc links for arm neon intrinsics
  • Adding doc links for arm crypto and aes intrinsics
  • Remove instruction tests for __mmask* intrinsics
  • Update ubuntu 21.10 docker containers to 22.04
  • Adding documentation links for arm crc32 intrinsics
  • Remove restrictions on compare-exchange memory ordering.
  • Fix a typo in the document.
  • Allow mapping a runtime feature to a set of target_features
  • Update atomic intrinsics
  • Fully qualify recursive macro calls
  • Ensure the neon vector aggregates like float32x4x4_t are #[repr(C)]
  • Remove useless conditional compilation
  • Fix ARM vbsl* NEON intrinsics

r? @Amanieu

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 23, 2022
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2022
@Amanieu
Copy link
Member

Amanieu commented Aug 23, 2022

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 23, 2022

📌 Commit 6d62f5cd2c8864d452553c569fd8efbc0dc97e86 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
@tmiasko
Copy link
Contributor Author

tmiasko commented Aug 23, 2022

@bors r- (unresolved links in documentation).

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2022
@rust-log-analyzer

This comment has been minimized.

@Amanieu
Copy link
Member

Amanieu commented Aug 24, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2022

📌 Commit 5f4d23d has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
@bors
Copy link
Contributor

bors commented Aug 25, 2022

⌛ Testing commit 5f4d23d with merge 7480389...

@bors
Copy link
Contributor

bors commented Aug 25, 2022

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 7480389 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2022
@bors bors merged commit 7480389 into rust-lang:master Aug 25, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 25, 2022
@tmiasko tmiasko deleted the update-stdarch branch August 25, 2022 21:28
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7480389): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.5%, -0.7%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
2.2% [2.1%, 2.2%] 2
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-3.1% [-3.8%, -2.5%] 2
All ❌✅ (primary) 0.1% [-2.2%, 2.5%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-3.0% [-3.9%, -2.2%] 4
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants